From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by sourceware.org (Postfix) with ESMTPS id E94C23858D35 for ; Thu, 10 Nov 2022 08:47:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E94C23858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x530.google.com with SMTP id v27so2043546eda.1 for ; Thu, 10 Nov 2022 00:47:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=5+t0NR6/7sSNyKIlr7BCyC7yCO/T7lo4UoMKNmd2H8M=; b=FoBddkVDYaZX+hIP3GYTpg8qJm9B8wDMaqwvHB7NdBwtATNMMBjr2YfZaVqgNpDWNb Tn947f7qgGXaUlWiv+kQE/GeauynCH3XHbeTG8bSJ1aS0r2UFdJvlMcRgXzAJ3TpHqsR bbwHxme+605avoZUh1A5FHNFL/Rukb1nCd+hLT10TWdRSkBplbQRMHsp9JEpgZABzLIo QTCKBZc8z7WPbce5Qply+xySPgMAUwHGaPcO/U8JKU6WNHRaCP4BEP0f67bpDoBbWDxd lfdSxVzxVtvA+9XS7bOshh1iXLE6MObtjSRe00ReVRFzJKibNq/D3Ljx1r6CtebmwBBG o3pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5+t0NR6/7sSNyKIlr7BCyC7yCO/T7lo4UoMKNmd2H8M=; b=XhT2vFKm30AgPopEU6LLfirK7rELwMs+vG6w6NP+qjVv0OCcNoAYwjBCbHs2TGokde xgGUOBIYghHx7rck98eoqMNMmsUIc+0JTRUSxE4pIK/ASzVU9ht2vFjb5R5dXU/mwgaL 8inbyxemMTQjkeVQi6SLzaSJAqwLLXnAmEzdZ3aXfufLVVLxrvoEPB5p7X8Fhv/OQzWj Y8WQQdNMrDiC76OUh9LyqL1zTRIrGwOxiHMIp0lVHqBaRl1PUidiZKLNOmZFtR7Vv0z9 vTSipcqHg1mtjtp+urizdNbB9zS6Padzi8y6uFBg4ZN5EYWCH8Zp4aspfL6GA0CUBeMh UaLA== X-Gm-Message-State: ACrzQf2PrVWBU0o58/lMpzRL5qecQScWB3o7rRJaxP598WDCSxMrT3i3 lp3AcDPvMLI6erCBOVM1dfdv8Rx71D/MjBj28IY= X-Google-Smtp-Source: AMsMyM4J4cXFT/3pAEFY30+F9+U8xgJZlyTbYIycGjO32lYvCOochD4DL+hnkKcW7I08VL6Yn3N4OAzHrHd/B+NDlRw= X-Received: by 2002:aa7:d3d3:0:b0:462:7435:8b14 with SMTP id o19-20020aa7d3d3000000b0046274358b14mr60308564edr.370.1668070077559; Thu, 10 Nov 2022 00:47:57 -0800 (PST) MIME-Version: 1.0 References: <1668042934-1377-1-git-send-email-apinski@marvell.com> In-Reply-To: From: Richard Biener Date: Thu, 10 Nov 2022 09:47:45 +0100 Message-ID: Subject: Re: [PATCH] Remove SLOW_SHORT_ACCESS from target headers To: Andrew Pinski Cc: apinski@marvell.com, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Nov 10, 2022 at 2:21 AM Andrew Pinski via Gcc-patches wrote: > > On Wed, Nov 9, 2022 at 5:16 PM apinski--- via Gcc-patches > wrote: > > > > From: Andrew Pinski > > > > SLOW_SHORT_ACCESS is defined in bfin and i386 target > > headers but the target macro is not used elsewhere. > > So let's remove it from those two headers and poison it. > > Just to add, this target macro was defined in GCC 2.8.0 in i386.h but > not used in any other sources. > apinski@xeond:~/src/upstream-gcc/gcc$ git grep SLOW_SHORT_ACCESS > releases/gcc-2.8.0 > releases/gcc-2.8.0:gcc/config/i386/i386.h:#define SLOW_SHORT_ACCESS 0 > > So it looks like it was never used for the last 24+ years and it is > time to finally remove it. OK. I notice you didn't remove any documentation so it was also undocumented? Thanks, Richard. > Thanks, > Andrew Pinski > > > > > > OK? Built x86_64-linux-gnu and bfin-elf. > > > > gcc/ChangeLog: > > > > * config/bfin/bfin.h (SLOW_SHORT_ACCESS): Delete. > > * config/i386/i386.h (SLOW_SHORT_ACCESS): Delete. > > * system.h: Poison SLOW_SHORT_ACCESS > > --- > > gcc/config/bfin/bfin.h | 1 - > > gcc/config/i386/i386.h | 3 --- > > gcc/system.h | 2 +- > > 3 files changed, 1 insertion(+), 5 deletions(-) > > > > diff --git a/gcc/config/bfin/bfin.h b/gcc/config/bfin/bfin.h > > index 4e7753038a8..1d75c655df8 100644 > > --- a/gcc/config/bfin/bfin.h > > +++ b/gcc/config/bfin/bfin.h > > @@ -810,7 +810,6 @@ typedef struct { > > subsequent accesses occur to other fields in the same word of the > > structure, but to different bytes. */ > > #define SLOW_BYTE_ACCESS 0 > > -#define SLOW_SHORT_ACCESS 0 > > > > /* Define this if most significant bit is lowest numbered > > in instructions that operate on numbered bit-fields. */ > > diff --git a/gcc/config/i386/i386.h b/gcc/config/i386/i386.h > > index b32db8da109..a5ad9f387f7 100644 > > --- a/gcc/config/i386/i386.h > > +++ b/gcc/config/i386/i386.h > > @@ -1933,9 +1933,6 @@ do { \ > > > > #define SLOW_BYTE_ACCESS 0 > > > > -/* Nonzero if access to memory by shorts is slow and undesirable. */ > > -#define SLOW_SHORT_ACCESS 0 > > - > > /* Define this macro if it is as good or better to call a constant > > function address than to call an address kept in a register. > > > > diff --git a/gcc/system.h b/gcc/system.h > > index c192b6c3ce7..de9c5c0d2ef 100644 > > --- a/gcc/system.h > > +++ b/gcc/system.h > > @@ -1075,7 +1075,7 @@ extern void fancy_abort (const char *, int, const char *) > > EH_FRAME_IN_DATA_SECTION TARGET_FLT_EVAL_METHOD_NON_DEFAULT \ > > JCR_SECTION_NAME TARGET_USE_JCR_SECTION SDB_DEBUGGING_INFO \ > > SDB_DEBUG NO_IMPLICIT_EXTERN_C NOTICE_UPDATE_CC \ > > - CC_STATUS_MDEP_INIT CC_STATUS_MDEP CC_STATUS > > + CC_STATUS_MDEP_INIT CC_STATUS_MDEP CC_STATUS SLOW_SHORT_ACCESS > > > > /* Hooks that are no longer used. */ > > #pragma GCC poison LANG_HOOKS_FUNCTION_MARK LANG_HOOKS_FUNCTION_FREE \ > > -- > > 2.17.1 > >