From: Richard Guenther <richard.guenther@gmail.com>
To: Nathan Sidwell <nathan@acm.org>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: fix cross build
Date: Thu, 24 May 2012 08:03:00 -0000 [thread overview]
Message-ID: <CAFiYyc0yY=JKg7za3bgdzAdHFYKCHEhRe47sOeDdMDLuZEV1mw@mail.gmail.com> (raw)
In-Reply-To: <4FBD2560.3010704@acm.org>
On Wed, May 23, 2012 at 7:58 PM, Nathan Sidwell <nathan@acm.org> wrote:
> On 05/22/12 15:12, Richard Guenther wrote:
>
>> But I wonder why CONSTRUCTORs do not inherit TREE_SIDE_EFFECTS
>> properly ...
>
>
> the attached patch fixes the ICE and causes no regressions on
> i686-pc-linux-gnu.
>
> ok?
Looks ok to me. Though I wonder how we got away with that for so long time ...
What do others prefer? Keep CONSTRUCTORs "broken" and paper over in
gimplify.c instead?
If you don't hear from somebody else in 24h the patch is ok as-is
(can you do some grepping whether there are callers of build_constructor
that set TREE_SIDE_EFFECTS on it afterwards?)
Thanks,
Richard.
> nathan
next prev parent reply other threads:[~2012-05-24 8:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-20 17:25 Nathan Sidwell
2012-05-21 10:04 ` Richard Guenther
2012-05-22 13:25 ` Nathan Sidwell
2012-05-22 14:12 ` Richard Guenther
2012-05-22 15:18 ` Nathan Sidwell
2012-05-23 17:59 ` Nathan Sidwell
2012-05-24 8:03 ` Richard Guenther [this message]
2012-05-27 16:28 ` Nathan Sidwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiYyc0yY=JKg7za3bgdzAdHFYKCHEhRe47sOeDdMDLuZEV1mw@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nathan@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).