From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-319456-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 15744 invoked by alias); 24 May 2012 08:03:51 -0000
Received: (qmail 15720 invoked by uid 22791); 24 May 2012 08:03:49 -0000
X-SWARE-Spam-Status: No, hits=-4.9 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE
X-Spam-Check-By: sourceware.org
Received: from mail-ob0-f175.google.com (HELO mail-ob0-f175.google.com) (209.85.214.175)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 24 May 2012 08:03:16 +0000
Received: by obhx4 with SMTP id x4so14050824obh.20        for <gcc-patches@gcc.gnu.org>; Thu, 24 May 2012 01:03:16 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.60.19.226 with SMTP id i2mr22072344oee.20.1337846595947; Thu, 24 May 2012 01:03:15 -0700 (PDT)
Received: by 10.76.83.230 with HTTP; Thu, 24 May 2012 01:03:15 -0700 (PDT)
In-Reply-To: <4FBD2560.3010704@acm.org>
References: <4FB928DA.8090806@acm.org>	<CAFiYyc0n6y9wQSe83JL+x9kmkXJ7kGLvhdRVNFnTQfzQwGkm1A@mail.gmail.com>	<4FBB93A4.5070509@acm.org>	<CAFiYyc3HpkaR+j-PiH+RNJ9Ava86Vf2eyu0GZ5VKrRK0Kz1Thg@mail.gmail.com>	<4FBD2560.3010704@acm.org>
Date: Thu, 24 May 2012 08:03:00 -0000
Message-ID: <CAFiYyc0yY=JKg7za3bgdzAdHFYKCHEhRe47sOeDdMDLuZEV1mw@mail.gmail.com>
Subject: Re: fix cross build
From: Richard Guenther <richard.guenther@gmail.com>
To: Nathan Sidwell <nathan@acm.org>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset=ISO-8859-1
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2012-05/txt/msg01599.txt.bz2

On Wed, May 23, 2012 at 7:58 PM, Nathan Sidwell <nathan@acm.org> wrote:
> On 05/22/12 15:12, Richard Guenther wrote:
>
>> But I wonder why CONSTRUCTORs do not inherit TREE_SIDE_EFFECTS
>> properly ...
>
>
> the attached patch fixes the ICE and causes no regressions on
> i686-pc-linux-gnu.
>
> ok?

Looks ok to me.  Though I wonder how we got away with that for so long time ...

What do others prefer?  Keep CONSTRUCTORs "broken" and paper over in
gimplify.c instead?

If you don't hear from somebody else in 24h the patch is ok as-is
(can you do some grepping whether there are callers of build_constructor
that set TREE_SIDE_EFFECTS on it afterwards?)

Thanks,
Richard.

> nathan