From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by sourceware.org (Postfix) with ESMTPS id 5AA983832347 for ; Mon, 5 Dec 2022 08:50:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5AA983832347 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-x236.google.com with SMTP id a7so12679596ljq.12 for ; Mon, 05 Dec 2022 00:50:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qMMpxamHn87/AJ4c24nXBRyGVH4SehbiR5YqYhkmooc=; b=o707AJU43iyY1ypOJcFG+/oRFj9AFw1B+VuMNYAOyjKgqx2iDhQlgyWLRUKcvSAg0A A5oXwVs1vU2LL9yMRJj9ktnDQrzlkjT7zw1JhDhaW9lB/a2S1v8Xqo/T6rc/1T4UoZ7e ZvlKRrSMSFPpsncCt35u5m2XS8prz4eUXIG6lST+rnbOvcNtzZGtAcrLJ0uWy+rS6JBZ UoqBDDzDvNs60ZMOUhYiFfYQ7IYf0TYUcfUMvWLejKKf3gd2eK8ETXljTdSCzBElY9FX hywCmsPzA64rcnrhnGzFbEz+rrrv65biH+e/rVrmswEWN1p45MMdxnAGBGGaQSUk5nlv NYvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qMMpxamHn87/AJ4c24nXBRyGVH4SehbiR5YqYhkmooc=; b=cfminU/Xf555vKIcZCkcalkEszPDgbl9FJO6ZRfP1X55EoqgzRSH91OBkso6RAM3M7 DqOa1KEE86NvEcH2kZK/cKPAD+qBId6OPWX9ol2BjyDko7SpDmH98KwYZzBo8KtVdVh1 XTNdwrMJXldrnns8U8xezTeLOZugOP/bv8W4OfOZYZgmD3UtUb3irHV43H4Elb3atYRs QviHMdfEn1UjWoIA1cVbEFojtU1ON7PNuBj/xqL4wen3Xz7yAu5K/9JWFtmUNVuOAf85 qRaBH7pun8xU8Gca2mFcv1mKTSanXnmK37mgvOX/y9qOtxc1AeIawcGne2sIQo5ucofb 7jWg== X-Gm-Message-State: ANoB5pn4mVl8JET0oFdbim/4pp75zZXczIHG1aqlS1LF3js4DHgouW/1 YdKIo6iiZFEXAChBl0MbB7/53AA4zsBzpeD763c= X-Google-Smtp-Source: AA0mqf7nP6Ew0hmyAH9eTU6ihblUN78SxuaEfqRYw1X7veBNRTHqy7XL0UmjPERy5OiLyEUfZwt4KGmetN/2bvesucc= X-Received: by 2002:a2e:98d5:0:b0:279:dc61:9922 with SMTP id s21-20020a2e98d5000000b00279dc619922mr4759664ljj.356.1670230218401; Mon, 05 Dec 2022 00:50:18 -0800 (PST) MIME-Version: 1.0 References: <905c34de-6333-1021-05e6-942922918b18@linux.ibm.com> <510a5367-def4-22eb-4a47-e81d1b38f5c9@linux.ibm.com> In-Reply-To: <510a5367-def4-22eb-4a47-e81d1b38f5c9@linux.ibm.com> From: Richard Biener Date: Mon, 5 Dec 2022 09:50:05 +0100 Message-ID: Subject: Re: [PATCH v2] Return a NULL rtx when targets don't support cbranchcc4 or predicate check fails in prepare_cmp_insn To: HAO CHEN GUI Cc: gcc-patches , Segher Boessenkool , David , "Kewen.Lin" , Peter Bergner Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Dec 5, 2022 at 9:43 AM HAO CHEN GUI wrote: > > Hi Richard, > > =E5=9C=A8 2022/12/5 15:31, Richard Biener =E5=86=99=E9=81=93: > > I wonder if you have a testcase you can add showing this change is > > worthwhile and > > fixes a bug? > > I want to enable cbranchcc4 on rs6000. But not all sub CCmode is > supported on rs6000. So the predicate check(assert) fails and it hits > ICE. I drafted two patches. This one is for the generic code, and > another is for rs6000. If this one is committed, cbranchcc4 can be > enabled on rs6000. Then I can create a testcase and let the predicate > check fail. Right now I can't write a testcase for it as it never > reaches the failure path. Fair enough. > Thanks a lot > Gui Haochen >