From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by sourceware.org (Postfix) with ESMTPS id 1B1FA38845AE for ; Wed, 19 Jun 2024 12:36:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1B1FA38845AE Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1B1FA38845AE Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::232 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718800566; cv=none; b=iAc6sixTQ5gHA1Vv/OZaBt8VE6uJDCkKaPiJ6FURdVNSZ79h7pwUfh+EmO4N7atbrZd8ixR2tHzXjm51I7FxuK9BGikURNIUGnC1nWW759yGres0Q85CdIhI+ESHM12qcUAzIPw38KDlF6Mu4vdMooWMfz2/U82JoQBO9UTyA3E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718800566; c=relaxed/simple; bh=DGd0/OUpbNyRjh2PExRRfvZ9JF9wBdBIKlRZyJvDlGk=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=AkY3IN0iYnDL/8r59J1l2vBSSEc1hFW4AITKSyVI+HaceyUKvS6yCIUadWNpmJMzy6f5+jj8Qry+Tq/nX9g4IikQX3seMT7IpbiXaUkcuna7BaVfYDjstwQU8NrlhPwt9lP8TMREvvs9WNnTuLIREzONl/ic7wd/c+mb6qNH7AY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-2ebd421a931so60802631fa.1 for ; Wed, 19 Jun 2024 05:36:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718800563; x=1719405363; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ismJD+6BTCsFyYnaO5TMiwUHfY7E4DOus+TnhaehqEo=; b=BQS/KDOQb7Lprj/Csdzig+ErcJWZO3mDyN2zJJrfmLxSTbpLF5Hcen3Nz+3iphOd8E 5XCImqBk6si4QvtjuRhVP/f/ija/OB2pVDCaG99ZNpl7kCuJLrAh7XBKii+oR+NzhDU0 fAn3yOf85ekmTVRj7HMY6OshbXCdFertCK9u1aQJh+1fBw8OsE1qPHdZtXnhR+5rkiF3 5gHzPYGZM5hq4Q/OxPqg2Tv1R6JgQfpCi5q4ecNJ4KvXDIyTY8Z2RCu3P/DeDCREXv5z e1z3U2cnk7Vlfbx8zBxY7yNQbSzSUKf9DKgxjmCx8CVyeiL+59pDBirjKXCNsI49raEB SUBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718800563; x=1719405363; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ismJD+6BTCsFyYnaO5TMiwUHfY7E4DOus+TnhaehqEo=; b=Ir2wt7SWNgX30N7q9vI2zlCpd4eD8io/N4g91/2KlGzG89AyiZit4uTYgoBL0IeWyq WOyP4tVhetMvAf8lkhNsd+f0VaiH5DsZjeaupgsClbveZ0IzXbYAAhXRtaSGvO86jWFj 0SsjwkvuhTiOsZOpyzZ2/pWg0xUX07F43aav21nOW/47/r43p9Uz4k2Er+UMcH7Lut1Q iU92L+yo3kOru7aLr+g0UkLqMWCvZa3NeYqqVqBBIQBwQsZ1Y79o1gg5zfGteiBmPaNI 9X7bAU+AB+Sijdwy5Pe1aoGtYTNITZ7V3z3QnhJUolIPvn6LXrxevJ5UeE4Wf7oU0oFv voxw== X-Gm-Message-State: AOJu0YxoQNIZWcqQTWC/crmD2gS13cKG+TXp1/tK7EmdFuNGWlyh3ElM m5Khp0t6joeBq8KEjfuA3yUk2BxhRqppGgUqow4Acg1GIIdAgx8/KPjG2JVmtBf25qn/sVUlPfo lEL3NbtihQVYWyA54OPaW28v8PhB+Gg== X-Google-Smtp-Source: AGHT+IGFtnXo8H8hnnYOR2m2CWzPywwmOSUYiCtRdUZnKvxIzsFXG4oxLMT107p0MP/Rf1PCl4Nn9Q3spuEQWzD8IV0= X-Received: by 2002:a2e:90d1:0:b0:2eb:d816:7a67 with SMTP id 38308e7fff4ca-2ec3ce94159mr15927241fa.16.1718800563384; Wed, 19 Jun 2024 05:36:03 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Richard Biener Date: Wed, 19 Jun 2024 14:35:52 +0200 Message-ID: Subject: Re: [PATCH 3/8] vect: Use one reduction_type local variable To: Feng Xue OS Cc: "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, Jun 16, 2024 at 9:23=E2=80=AFAM Feng Xue OS wrote: > > Two local variables were defined to refer same STMT_VINFO_REDUC_TYPE, bet= ter > to keep only one. OK. Richard. > Thanks, > Feng > > --- > gcc/ > * tree-vect-loop.cc (vectorizable_reduction): Remove v_reduc_type= , and > replace it to another local variable reduction_type. > --- > gcc/tree-vect-loop.cc | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/gcc/tree-vect-loop.cc b/gcc/tree-vect-loop.cc > index 6e8b3639daf..0f7b125e72d 100644 > --- a/gcc/tree-vect-loop.cc > +++ b/gcc/tree-vect-loop.cc > @@ -7868,10 +7868,10 @@ vectorizable_reduction (loop_vec_info loop_vinfo, > if (lane_reducing) > STMT_VINFO_REDUC_VECTYPE_IN (stmt_info) =3D vectype_in; > > - enum vect_reduction_type v_reduc_type =3D STMT_VINFO_REDUC_TYPE (phi_i= nfo); > - STMT_VINFO_REDUC_TYPE (reduc_info) =3D v_reduc_type; > + enum vect_reduction_type reduction_type =3D STMT_VINFO_REDUC_TYPE (phi= _info); > + STMT_VINFO_REDUC_TYPE (reduc_info) =3D reduction_type; > /* If we have a condition reduction, see if we can simplify it further= . */ > - if (v_reduc_type =3D=3D COND_REDUCTION) > + if (reduction_type =3D=3D COND_REDUCTION) > { > if (slp_node && SLP_TREE_LANES (slp_node) !=3D 1) > return false; > @@ -8038,7 +8038,7 @@ vectorizable_reduction (loop_vec_info loop_vinfo, > > STMT_VINFO_REDUC_CODE (reduc_info) =3D orig_code; > > - vect_reduction_type reduction_type =3D STMT_VINFO_REDUC_TYPE (reduc_in= fo); > + reduction_type =3D STMT_VINFO_REDUC_TYPE (reduc_info); > if (reduction_type =3D=3D TREE_CODE_REDUCTION) > { > /* Check whether it's ok to change the order of the computation. > -- > 2.17.1