From: Richard Biener <richard.guenther@gmail.com>
To: Sergei Trofimovich <slyfox@gentoo.org>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Martin Liska <mliska@suse.cz>,
Sergei Trofimovich <siarheit@google.com>
Subject: Re: [PATCH] -fprofile-reproducible: fix option value handling
Date: Mon, 14 Sep 2020 09:34:08 +0200 [thread overview]
Message-ID: <CAFiYyc1+N1n1cmXD7MOmLZK2Exc6owwmqWu1VaXiYP6saqT79A@mail.gmail.com> (raw)
In-Reply-To: <20200911215518.2646852-1-slyfox@gentoo.org>
On Fri, Sep 11, 2020 at 11:56 PM Sergei Trofimovich via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> From: Sergei Trofimovich <siarheit@google.com>
>
> Before the change option handling did not accept an argument:
> xgcc: error: unknown profile reproducibility method '=serial'
> xgcc: note: valid arguments to '-fprofile-reproducible' are: multithreaded parallel-runs serial; did you mean 'serial'?
>
> The change also includes trailing '=' as part of option prefix.
Does it still work without an option then?
OK if so.
> gcc/ChangeLog:
>
> * common.opt: Fix handling of '-fprofile-reproducible' option.
> ---
> gcc/common.opt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/common.opt b/gcc/common.opt
> index dd68c61ae1d..84bf521128d 100644
> --- a/gcc/common.opt
> +++ b/gcc/common.opt
> @@ -2228,7 +2228,7 @@ Enum(profile_reproducibility) String(parallel-runs) Value(PROFILE_REPRODUCIBILIT
> EnumValue
> Enum(profile_reproducibility) String(multithreaded) Value(PROFILE_REPRODUCIBILITY_MULTITHREADED)
>
> -fprofile-reproducible
> +fprofile-reproducible=
> Common Joined RejectNegative Var(flag_profile_reproducible) Enum(profile_reproducibility) Init(PROFILE_REPRODUCIBILITY_SERIAL)
> -fprofile-reproducible=[serial|parallel-runs|multithreaded] Control level of reproducibility of profile gathered by -fprofile-generate.
>
> --
> 2.28.0
>
next prev parent reply other threads:[~2020-09-14 7:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 21:55 Sergei Trofimovich
2020-09-14 7:34 ` Richard Biener [this message]
2020-09-14 22:57 ` Sergei Trofimovich
2020-09-15 6:40 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc1+N1n1cmXD7MOmLZK2Exc6owwmqWu1VaXiYP6saqT79A@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mliska@suse.cz \
--cc=siarheit@google.com \
--cc=slyfox@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).