From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by sourceware.org (Postfix) with ESMTPS id 028BA3858CDA for ; Mon, 26 Sep 2022 08:21:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 028BA3858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x62a.google.com with SMTP id nb11so12397101ejc.5 for ; Mon, 26 Sep 2022 01:21:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=5cEmebybaFtT+AYR1LjacsK50eCJA5wl0NItndIgBb0=; b=jPDqOJx2Nm8oh9uvExBDP1VaNETb/Dy/MyxbdOt57iidB805B4Gkt/iq3rxHZAPO32 3ax8y72s2X9PR+6cLropCTZ40yYB6D8fztgYHP4LBb2fT++GTRo8kUrya+Sx8Lfn/2C7 pi3cbfhcrGzmDpWBkAsqM4lBXW9+xsKk0ZM+vJXlNZ14BAz4i3+QopSU2D17nLVCF3kl s3rzqz9X4H/l0HYlp0W/619dIxVJT9QO0OZgm9JwXacaIlcDV+uVxtOISZgUa8GzXNDJ CkChwOQwJuL2nO98YDp3ZdPeAIL/567VU94ml4ayNo1nhSUDzJzdDcSTbNLv9Qws/1LR jS8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=5cEmebybaFtT+AYR1LjacsK50eCJA5wl0NItndIgBb0=; b=ZmfJO4u6pgtRfjWlylwII4FJ6dBR8NrHzAg9X+FBDljZgZGRo6mERHbSOAJ2QUlP6C 624m9bw3kWId/etZE12xIpZ4xghvNiOklhPYVW1p3cVF8GS4VU+eRglW3pfEri9p6s25 iXA2zY84IiA8E2p/XG0Pd8fswGyBSFY1vBjMcKudBElYDUfFovm6A416rmrj3l8/fhca rBFvQmDCq/rC9zw9r9a91xA1KB7ACCcDgCcTwMRYyaBQebu5vnnyxWcDTCNU339rOWuH 3xK2VHGcclZQV/STQ4dQzXPrTNXabJcNx1P1RPOCJYZRH2CuUU+GRFXW+z2lGFtTxAbM h7wg== X-Gm-Message-State: ACrzQf0adllGSJnESXJplpQcdadHt/Ca9701Q4xK4tDRYsnZEpEhnCrK gA1q5hZCCGblbnxKnlHhYsUPp/ocrDd/EXIeJYE= X-Google-Smtp-Source: AMsMyM7ajFFOccAnoU7UySg/CMoS6iX5WTeywIhYsvCWn7O573Ys0AhiyMcAfxEmTZaWllzlgclEO1PVfsEn7QcPlXk= X-Received: by 2002:a17:906:8251:b0:781:8016:2dc9 with SMTP id f17-20020a170906825100b0078180162dc9mr17879482ejx.488.1664180480669; Mon, 26 Sep 2022 01:21:20 -0700 (PDT) MIME-Version: 1.0 References: <20220926065604.783193-1-liwei.xu@intel.com> In-Reply-To: <20220926065604.783193-1-liwei.xu@intel.com> From: Richard Biener Date: Mon, 26 Sep 2022 10:21:07 +0200 Message-ID: Subject: Re: [PATCH] Optimize nested permutation to single VEC_PERM_EXPR [PR54346] To: Liwei Xu , Richard Sandiford Cc: gcc-patches@gcc.gnu.org, wilson@tuliptree.org, admin@levyhsu.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Sep 26, 2022 at 8:58 AM Liwei Xu wrote: > > This patch implemented the optimization in PR 54346, which Merges > > c = VEC_PERM_EXPR ; > d = VEC_PERM_EXPR ; > to > d = VEC_PERM_EXPR ; > > Bootstrapped and regtested on x86_64-pc-linux-gnu{-m32,} > tree-ssa/forwprop-19.c fail to pass but I'm not sure whether it > is ok to removed it. Looks good, but leave Richard a chance to ask for VLA vector support which might be trivial to do. Btw, doesn't this handle the VEC_PERM + VEC_PERM case in tree-ssa-forwprop.cc:simplify_permutation as well? Note _that_ does seem to handle VLA vectors. Thanks, Richard. > gcc/ChangeLog: > > PR target/54346 > * match.pd: Merge the index of VCST then generates the new vec_perm. > > gcc/testsuite/ChangeLog: > > PR target/54346 > * gcc.dg/pr54346.c: New test. > > Co-authored-by: liuhongt > --- > gcc/match.pd | 41 ++++++++++++++++++++++++++++++++++ > gcc/testsuite/gcc.dg/pr54346.c | 13 +++++++++++ > 2 files changed, 54 insertions(+) > create mode 100755 gcc/testsuite/gcc.dg/pr54346.c > > diff --git a/gcc/match.pd b/gcc/match.pd > index 345bcb701a5..9219b0a10e1 100644 > --- a/gcc/match.pd > +++ b/gcc/match.pd > @@ -8086,6 +8086,47 @@ and, > (minus (mult (vec_perm @1 @1 @3) @2) @4))) > > > +/* (PR54346) Merge > + c = VEC_PERM_EXPR ; > + d = VEC_PERM_EXPR ; > + to > + d = VEC_PERM_EXPR ; */ > + > +(simplify > + (vec_perm (vec_perm@0 @1 @2 VECTOR_CST@3) @0 VECTOR_CST@4) > + (with > + { > + if(!TYPE_VECTOR_SUBPARTS (type).is_constant()) > + return NULL_TREE; > + > + tree op0; > + machine_mode result_mode = TYPE_MODE (type); > + machine_mode op_mode = TYPE_MODE (TREE_TYPE (@1)); > + int nelts = TYPE_VECTOR_SUBPARTS (type).to_constant(); > + vec_perm_builder builder0; > + vec_perm_builder builder1; > + vec_perm_builder builder2 (nelts, nelts, 1); > + > + if (!tree_to_vec_perm_builder (&builder0, @3) > + || !tree_to_vec_perm_builder (&builder1, @4)) > + return NULL_TREE; > + > + vec_perm_indices sel0 (builder0, 2, nelts); > + vec_perm_indices sel1 (builder1, 1, nelts); > + > + for (int i = 0; i < nelts; i++) > + builder2.quick_push (sel0[sel1[i].to_constant()]); > + > + vec_perm_indices sel2 (builder2, 2, nelts); > + > + if (!can_vec_perm_const_p (result_mode, op_mode, sel2, false)) > + return NULL_TREE; > + > + op0 = vec_perm_indices_to_tree (TREE_TYPE (@4), sel2); > + } > + (vec_perm @1 @2 { op0; }))) > + > + > /* Match count trailing zeroes for simplify_count_trailing_zeroes in fwprop. > The canonical form is array[((x & -x) * C) >> SHIFT] where C is a magic > constant which when multiplied by a power of 2 contains a unique value > diff --git a/gcc/testsuite/gcc.dg/pr54346.c b/gcc/testsuite/gcc.dg/pr54346.c > new file mode 100755 > index 00000000000..d87dc3a79a5 > --- /dev/null > +++ b/gcc/testsuite/gcc.dg/pr54346.c > @@ -0,0 +1,13 @@ > +/* { dg-do compile } */ > +/* { dg-options "-O -fdump-tree-dse1" } */ > + > +typedef int veci __attribute__ ((vector_size (4 * sizeof (int)))); > + > +void fun (veci a, veci b, veci *i) > +{ > + veci c = __builtin_shuffle (a, b, __extension__ (veci) {1, 4, 2, 7}); > + *i = __builtin_shuffle (c, __extension__ (veci) { 7, 2, 1, 5 }); > +} > + > +/* { dg-final { scan-tree-dump "VEC_PERM_EXPR.*{ 3, 6, 0, 0 }" "dse1" } } */ > +/* { dg-final { scan-tree-dump-times "VEC_PERM_EXPR" 1 "dse1" } } */ > \ No newline at end of file > -- > 2.18.2 >