From: Richard Biener <richard.guenther@gmail.com>
To: Marek Polacek <polacek@redhat.com>
Cc: "Joseph S. Myers" <joseph@codesourcery.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fix PR56344
Date: Mon, 02 Dec 2013 15:01:00 -0000 [thread overview]
Message-ID: <CAFiYyc1-Z2GyG53+CDACc4afy7X2bCXzCbKKRhtTLZeFmMxGmQ@mail.gmail.com> (raw)
In-Reply-To: <20130313125702.GF18923@redhat.com>
On Wed, Mar 13, 2013 at 1:57 PM, Marek Polacek <polacek@redhat.com> wrote:
> Ping.
Ok. (yay, oldest patch in my review queue ...)
Thanks,
Richard.
> On Tue, Mar 05, 2013 at 05:06:21PM +0100, Marek Polacek wrote:
>> On Fri, Mar 01, 2013 at 09:41:27AM +0100, Richard Biener wrote:
>> > On Wed, Feb 27, 2013 at 6:38 PM, Joseph S. Myers
>> > <joseph@codesourcery.com> wrote:
>> > > On Wed, 27 Feb 2013, Richard Biener wrote:
>> > >
>> > >> Wouldn't it be better to simply pass this using the variable size handling
>> > >> code? Thus, initialize args_size.var for too large constant size instead?
>> > >
>> > > Would that be compatible with the ABI definition of how a large (constant
>> > > size) argument should be passed?
>> >
>> > I'm not sure. Another alternative is to expand to __builtin_trap (), but that's
>> > probably not easy at this very point.
>> >
>> > Or simply fix the size calculation to not overflow (either don't count bits
>> > or use a double-int).
>>
>> I don't think double_int will help us here. We won't detect overflow,
>> because we overflowed here (when lower_bound is an int):
>> lower_bound = INTVAL (XEXP (XEXP (arg->stack_slot, 0), 1));
>> The value from INTVAL () fits when lower_bound is a double_int, but
>> then:
>> i = lower_bound;
>> ...
>> stack_usage_map[i]
>> the size of stack_usage_map is stored in highest_outgoing_arg_in_use,
>> which is an int, so we're limited by an int size here.
>> Changing the type of highest_outgoing_arg_in_use from an int to a
>> double_int isn't worth the trouble, IMHO.
>>
>> Maybe the original approach, only with sorry () instead of error ()
>> and e.g. HOST_BITS_PER_INT - 1 instead of 30 would be appropriate
>> after all. Dunno.
>>
>> Marek
next prev parent reply other threads:[~2013-12-02 15:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-26 18:27 Marek Polacek
2013-02-26 23:17 ` Joseph S. Myers
2013-02-27 9:56 ` Marek Polacek
2013-02-27 11:33 ` Richard Biener
2013-02-27 17:38 ` Joseph S. Myers
2013-03-01 8:41 ` Richard Biener
2013-03-05 16:06 ` Marek Polacek
2013-03-13 12:57 ` Marek Polacek
2013-12-02 15:01 ` Richard Biener [this message]
2013-12-02 16:40 ` Marek Polacek
2013-12-02 19:19 ` Marek Polacek
2013-12-02 20:35 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc1-Z2GyG53+CDACc4afy7X2bCXzCbKKRhtTLZeFmMxGmQ@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=polacek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).