From: Richard Biener <richard.guenther@gmail.com>
To: "Kewen.Lin" <linkw@linux.ibm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Richard Sandiford <richard.sandiford@arm.com>
Subject: Re: [PATCH] vect: Fix wrong check in vect_recog_mulhs_pattern [PR101596]
Date: Tue, 27 Jul 2021 10:57:28 +0200 [thread overview]
Message-ID: <CAFiYyc10o3zcaH0_h1Bm9m_bKK4PE1He-BMyzJO+A5wRQ6Dxfw@mail.gmail.com> (raw)
In-Reply-To: <f9e48ed1-dfa5-e710-7fc9-ea51f430864a@linux.ibm.com>
On Tue, Jul 27, 2021 at 5:21 AM Kewen.Lin <linkw@linux.ibm.com> wrote:
>
> Hi,
>
> As PR101596 showed, vect_recog_mulhs_pattern uses target_precision to
> check the scale_term is expected or not, it could be wrong when the
> precision of the actual used new_type larger than target_precision as
> shown by the example.
>
> This patch is to use precision of new_type instead of target_precision
> for the scale_term matching check.
>
> Bootstrapped & regtested on powerpc64le-linux-gnu P10,
> powerpc64-linux-gnu P8, x86_64-redhat-linux and aarch64-linux-gnu.
>
> Is it ok for trunk?
OK.
Richard.
> BR,
> Kewen
> -----
> gcc/ChangeLog:
>
> PR tree-optimization/100696
> * tree-vect-patterns.c (vect_recog_mulhs_pattern): Fix wrong check
> by using new_type's precision instead.
>
> gcc/testsuite/ChangeLog:
>
> PR tree-optimization/100696
> * gcc.target/powerpc/pr101596-1.c: New test.
> * gcc.target/powerpc/pr101596-2.c: Likewise.
> * gcc.target/powerpc/pr101596-3.c: Likewise.
prev parent reply other threads:[~2021-07-27 8:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 3:20 Kewen.Lin
2021-07-27 8:57 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc10o3zcaH0_h1Bm9m_bKK4PE1He-BMyzJO+A5wRQ6Dxfw@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=linkw@linux.ibm.com \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).