From: Richard Biener <richard.guenther@gmail.com>
To: Andrew Pinski <apinski@marvell.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 1/2] Support get_range_query with a nullptr argument
Date: Mon, 20 Feb 2023 09:01:54 +0100 [thread overview]
Message-ID: <CAFiYyc10ypGu_9goQqhjzO9uvNsxX1QJoGy0jXx2oRPrG6iOig@mail.gmail.com> (raw)
In-Reply-To: <20230217214538.2177094-1-apinski@marvell.com>
On Fri, Feb 17, 2023 at 10:46 PM Andrew Pinski via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> get_range_query didn't support a nullptr argument
> before and would crash.
> See also the thread at
> https://inbox.sourceware.org/gcc/4f6718af-e17a-41ef-a886-f45e4ac3d7a4@redhat.com/T/
>
> OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions.
OK.
> gcc/ChangeLog:
>
> * value-query.h (get_range_query): Return the global ranges
> for a nullptr func.
> ---
> gcc/value-query.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/value-query.h b/gcc/value-query.h
> index 63878968118..2d7bf8fcf33 100644
> --- a/gcc/value-query.h
> +++ b/gcc/value-query.h
> @@ -140,7 +140,7 @@ get_global_range_query ()
> ATTRIBUTE_RETURNS_NONNULL inline range_query *
> get_range_query (const struct function *fun)
> {
> - return fun->x_range_query ? fun->x_range_query : &global_ranges;
> + return (fun && fun->x_range_query) ? fun->x_range_query : &global_ranges;
> }
>
> // Query the global range of NAME in function F. Default to cfun.
> --
> 2.17.1
>
prev parent reply other threads:[~2023-02-20 10:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 21:45 Andrew Pinski
2023-02-17 21:45 ` [PATCH 2/2] Remove #if GIMPLE around 1 - a pattern Andrew Pinski
2023-02-17 22:12 ` Jeff Law
2023-02-20 8:01 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc10ypGu_9goQqhjzO9uvNsxX1QJoGy0jXx2oRPrG6iOig@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=apinski@marvell.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).