From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by sourceware.org (Postfix) with ESMTPS id 946FB3858C60 for ; Mon, 23 Oct 2023 07:46:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 946FB3858C60 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 946FB3858C60 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::136 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698047187; cv=none; b=fOv5qZDBedtxNF0UO4plzQV2iNSOKsb5hmcbmlxpENqEk/S0LZ5fjPda7geFh6qKavOUnBbDZcpOTFSgZevzwzWwqU1rzA1/cKAf4dK3Djng3aiGU8sYLDaw78+4Z92r5VFAYXiGZEo8TJDnfY+aUZMvkPXjxXHQsXoIQxyCcBM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698047187; c=relaxed/simple; bh=oj8QBC9rvOHjKEuro3BSulJb2HzlDfVddQrDTzwAsNI=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=lt2IpuuXHrTUGa4R5LJDC5kMlpZaNx2VKMCTS6ETkHfzdgk4u1LeXrH26/C9TbpHgkwkcb9NOBW8vP0R5u9hSpX38EXi9gVw33JjyWPMBLns3POTuWlkq9/savdwW42VyNpoGQ0qSlO+CufdyiUnsqsFBq5PhIiJWtTXNDSvW08= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-507cee17b00so4309508e87.2 for ; Mon, 23 Oct 2023 00:46:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698047183; x=1698651983; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=M4uiXkmXCUHmQtTCMkIL7WqG/n8pvsfsqJQd7gBP1Gc=; b=hIfcs24KjB+/R6pXlKydCBlHLYas3oqFRR1UGWW3htjbKS6L2mmEx9ZFNKXpBUOr6w 6DX8bVYJRzrl3fz7KhqJLExyU7oUyi01UjSam7Blu+ntlfYXnBl3KMaGTrtvO3yLrtgO 5d2cnUKrKdY1LaNm1BIzbiXP7M6uet9J88fEGSzIeQx3LqZWhUhIdUBHjGtlFdh1tcqP WqyVAYoC1RMzFMvJhoV6aLkF/98I1Wrnmt+yy2tYCf9XecMyX06sSSf/lU/XVNyxm8xx yok0DHAVKn8NTW/6axtOObRbk1MHXSQ3qNmKrPYjCN2ZEyfi991tZChMMJWaP9jg+DH9 Aj8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698047183; x=1698651983; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=M4uiXkmXCUHmQtTCMkIL7WqG/n8pvsfsqJQd7gBP1Gc=; b=gw7PEBis+/85dRc6spGz1Ikp7CvmZAK8nLZN2H8MVQAgufypeYnwb3v1g9GMSetPWi i6wieYWsb0REohov89LpgFLlXKoNVoUeFX4wH4qBC3lHLJaY+PdKU1OoZsXaxVOt2Pfi M/AAzvhfwrX4rEB2gjknexs+xTCYbYx01qJmfp1mCkfui0bhWNSil0G4BanML6kfRsuw 1n3W6w5gwW5eK4vTHT+YGuqelCXP5kEKaPjC8WuGr/1EvjiMI0pn93RkzTF/aNNqE7DO ENCeaMCQVafbfSKZoR978dYwlfJtvO2QwEQMhcxgL8gyYdIESkb7E7LreRJD8WfFlhac I0BQ== X-Gm-Message-State: AOJu0Yx+BRJIp0txLE413YRyyhwNUMCddsnGU8O/KQw6yHOtVUXGxbzZ nX8rBAXAE6D++68mvxhzfPWinVslL7sS5Kjzu0s= X-Google-Smtp-Source: AGHT+IGNFyyGexQCbZJlVkQ3AjeuyrmhnE3YRxPg6A3yILCjMmMqXSV6n3iuoG1BDDSG8vIRDXuUU2Vhabq4TOap70U= X-Received: by 2002:a05:6512:2253:b0:507:9784:644c with SMTP id i19-20020a056512225300b005079784644cmr5720117lfu.26.1698047183210; Mon, 23 Oct 2023 00:46:23 -0700 (PDT) MIME-Version: 1.0 References: <20231021180712.370694-1-pinskia@gmail.com> In-Reply-To: <20231021180712.370694-1-pinskia@gmail.com> From: Richard Biener Date: Mon, 23 Oct 2023 09:43:19 +0200 Message-ID: Subject: Re: [PATCH] convert_to_complex vs invalid_conversion [PR111903] To: Andrew Pinski Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, Oct 21, 2023 at 8:07=E2=80=AFPM Andrew Pinski w= rote: > > convert_to_complex when creating a COMPLEX_EXPR does > not currently check if either the real or imag parts > was not error_mark_node. This later on confuses the gimpilfier > when there was a SAVE_EXPR wrapped around that COMPLEX_EXPR. > The simple fix is after calling convert inside convert_to_complex_1, > check that the either result was an error_operand and return > an error_mark_node in that case. > > Bootstrapped and tested on x86_64-linux-gnu with no regressions. OK. Richard. > PR c/111903 > > gcc/ChangeLog: > > * convert.cc (convert_to_complex_1): Return > error_mark_node if either convert was an error > when converting from a scalar. > > gcc/testsuite/ChangeLog: > > * gcc.target/i386/float16-8.c: New test. > --- > gcc/convert.cc | 9 +++++++-- > gcc/testsuite/gcc.target/i386/float16-8.c | 12 ++++++++++++ > 2 files changed, 19 insertions(+), 2 deletions(-) > create mode 100644 gcc/testsuite/gcc.target/i386/float16-8.c > > diff --git a/gcc/convert.cc b/gcc/convert.cc > index 80d86fe3708..ac6af7026a7 100644 > --- a/gcc/convert.cc > +++ b/gcc/convert.cc > @@ -1006,8 +1006,13 @@ convert_to_complex_1 (tree type, tree expr, bool f= old_p) > case ENUMERAL_TYPE: > case BOOLEAN_TYPE: > case BITINT_TYPE: > - return build2 (COMPLEX_EXPR, type, convert (subtype, expr), > - convert (subtype, integer_zero_node)); > + { > + tree real =3D convert (subtype, expr); > + tree imag =3D convert (subtype, integer_zero_node); > + if (error_operand_p (real) || error_operand_p (imag)) > + return error_mark_node; > + return build2 (COMPLEX_EXPR, type, real, imag); > + } > > case COMPLEX_TYPE: > { > diff --git a/gcc/testsuite/gcc.target/i386/float16-8.c b/gcc/testsuite/gc= c.target/i386/float16-8.c > new file mode 100644 > index 00000000000..003f82e7146 > --- /dev/null > +++ b/gcc/testsuite/gcc.target/i386/float16-8.c > @@ -0,0 +1,12 @@ > +/* { dg-do compile } */ > +/* { dg-options "-mno-sse" } */ > +/* PR c/111903 */ > + > +int i; > +_Float16 f; > +int bar(...); > +void > +foo (void) > +{ > + i /=3D bar ((_Complex _Float16) f); /* { dg-error "" } */ > +} > -- > 2.39.3 >