From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by sourceware.org (Postfix) with ESMTPS id 015583858415; Fri, 9 Jun 2023 09:03:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 015583858415 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2b1b92845e1so16295271fa.0; Fri, 09 Jun 2023 02:03:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686301381; x=1688893381; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=dNlS4oAvP66hIJ848OvsWlOmYsyud+5zZnCXfj/LdEw=; b=HK5AKxiCPxaf1UyIvlPGUEe8LLz4mSM8dd+8f/Nl4an7XbIwct0KT9TVJFYhwlImCK UEH2f9BsrYM9ttnPQdLeHPJI4C8r+zj0/ZlIXxZBPAsAzlxPARura8fVmWNQUMGbTrHd op4lmuyYlNeRlmV1q6XsR+xr7FX+2IR3UWFHsmCTfaMAyU2eCNKAe2t2QJ0/HsfkAnXy ZADDZXVLEaaCJoVEv5pmBzWPNHSa8t2CHF0o4pHrlmiBYzMnMedaYmvtFULGTAZokNKb pKMLVxgFy0KdYtnbAxgfj8t/9DAfDfT6qITfo43T2m4YYOTUGfW/XrodP0uq7pIqUrHj NwRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686301381; x=1688893381; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dNlS4oAvP66hIJ848OvsWlOmYsyud+5zZnCXfj/LdEw=; b=C30HwavE7mHr+wJNBeO1/e7iOOUY6Gk20YcFV7qtj404TTIcEea+Ka34q/haN/6AXt 4yC9GkRsxSE6xE0G3u0EeIyaetXbfU4QGcbs37n5nPsJ4/ZvHafuKfMmSw41Y/v7RtWc diOrQxatvYeHkcz4d0b98YP6KxyQPijlcuDV+ljZyLJnQnFqSP0tWmbGTTgWHJFxGAjR 0s5b7/yks1SeJJEB5YrRANg3PupkFJzy5CNUjJV0LsPWOGFUKvwMBbZaOf5zRMYLkY2q LbXFwxZkBx2vKf2tH997GgP91V1AYtQysnZda6FSvGlP6ENb3GPgAUcETJ8vXLo0YQ53 zV9A== X-Gm-Message-State: AC+VfDznTTaHaYRB0k4t7aSKdwieH6ZlB1dPYMx6lJGCOtCcYi2cLYML 02CucA4Rb++YXaFbbZQB2E/AG4KnzRJ066gIgIcU6MtQ X-Google-Smtp-Source: ACHHUZ7V+Wei9/3F5rmHYj+w8IFDDgxVtNMe14Z0C9UddHhIAYkCceuP8NSvEuO5AhmrWEr2vQfmqiVShHNwZYbbpWQ= X-Received: by 2002:a2e:a167:0:b0:2b1:a3e6:1fa8 with SMTP id u7-20020a2ea167000000b002b1a3e61fa8mr592706ljl.49.1686301381211; Fri, 09 Jun 2023 02:03:01 -0700 (PDT) MIME-Version: 1.0 References: <20230524185559.1285583-1-jason@redhat.com> In-Reply-To: From: Richard Biener Date: Fri, 9 Jun 2023 11:02:48 +0200 Message-ID: Subject: Re: [PATCH RFC] c++: use __cxa_call_terminate for MUST_NOT_THROW [PR97720] To: Jonathan Wakely Cc: Jason Merrill , gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Jun 8, 2023 at 3:14=E2=80=AFPM Jonathan Wakely via Gcc-patches wrote: > > On Fri, 26 May 2023 at 10:58, Jonathan Wakely wrote: > > > > > > > On Wed, 24 May 2023 at 19:56, Jason Merrill via Libstdc++ < > > libstdc++@gcc.gnu.org> wrote: > > > >> Middle-end folks: any thoughts about how best to make the change > >> described in > >> the last paragraph below? > >> > >> Library folks: any thoughts on the changes to __cxa_call_terminate? > >> > > > > I see no harm in exporting it (with the adjusted signature). The "looks > > standard but isn't" name is a little unfortunate, but not a big deal. > > > > Jason, do you have any objection to exporting __cxa_call_terminate for GC= C > 13.2 as well, even though the FE won't use it? > > Currently both gcc-13 and trunk are at the same library version, > libstdc++.so.6.0.32 > > But with this addition to trunk we need to bump that .32 to .33, meaning > that gcc-13 and trunk diverge. If we want to backport any new symbols fro= m > trunk to gcc-13 that gets trickier once they've diverged. But if you backport any new used symbol you have to bump the version anyway. So why not bump now (on trunk)? > If we added __cxa_call_terminate to gcc-13, making it another new additio= n > to libstdc++.so.6.0.32, then it would simplify a few things. > > In theory it could be a problem for distros already shipping gcc-13.1.1 > with that new libstdc++.so.6.0.32 version, but since the > __cxa_call_terminate symbol won't actually be used by the gcc-13.1.1 > compilers, I don't think it will be a problem.