From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by sourceware.org (Postfix) with ESMTPS id DCC723858D32 for ; Mon, 19 Sep 2022 07:44:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DCC723858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x530.google.com with SMTP id f20so35559199edf.6 for ; Mon, 19 Sep 2022 00:44:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=20wWdEIl8Es48O2qnaQpGf7hfmUYcJ4mz0gb4Ik5qds=; b=muukOD+uJvdeOi98h+OrlHyQRhlYiMS5nJytdcdGKXvhK26UrMsUKW5/VhRd4Jjvuv 2a5ynd0ThRx7MVdydVnBCkGtnXqBfDBdQ2Rn2/tjIXuG28HC/G4NqO2Caj8737wqwLvR GPeS+llPQyPqQ+wu1E0il0TF9BUW5wjrAHShsC6qo1JK/GEIUFkjhzLSRrhC1JePxPFB xg0PNioalZjOrSKdiY0KImpEv5RlhFAcr1nWNauTFFkcSHizlW8kI7Mat+KpNveaDQKR /twc+ze91Whvl0YNUwouWd4qmrYEjwAUh6dYV1Tx4wX4qvyoGWM+KvCdVzj6tjJjuEyb smpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=20wWdEIl8Es48O2qnaQpGf7hfmUYcJ4mz0gb4Ik5qds=; b=VDvqH19+m7Efx9TE6ZHRkGS0YHMCA4K++9OVUJ57GKJZB6qLmq8Pvi9G89xBErQGdy a1YYSaE4VXlV7HfFAqJHtEdFLga4cbr77LyVwl1t5hUHNY+V+dx0ZdzX2F4u6cwA7kI9 54q1AEGHbsQUsLG5UAJxEBo5rI5hZmatActrYDp5tnFKi+C21FjAmtUQSmBc005N5rcP tQvWb8ziVFtU46ctjaijbsD2DAE7ao3TK+QIC9JBZ0F4FbiB1wefNFlKHzYRYA9BTeet rbgOLOii+/jEglz0VlGjMksNUnuagVHwcWwLScRtTg4g+nixJuNP/6ab7Wn9Dc6hjloA Dz1Q== X-Gm-Message-State: ACrzQf3BvCEmPnjq7EAC0+gmux+K3frw+/2MB7lBJPABxpxKjvEsTdKY GQXbs5GGrd4CkI5DNa7ByuKwg29XKKb7a7vqscg= X-Google-Smtp-Source: AMsMyM5K/Ux50PeNLj9fq279c5CINwZNF9haUEoS1edYwCJV9uORA/UB3kZqcKaVj/gDP/XAJGJ2bJmEBno75vJuWFM= X-Received: by 2002:a05:6402:3786:b0:451:24da:f8c9 with SMTP id et6-20020a056402378600b0045124daf8c9mr14526057edb.250.1663573458540; Mon, 19 Sep 2022 00:44:18 -0700 (PDT) MIME-Version: 1.0 References: <20220918090708.4014343-1-torbjorn.svensson@foss.st.com> In-Reply-To: <20220918090708.4014343-1-torbjorn.svensson@foss.st.com> From: Richard Biener Date: Mon, 19 Sep 2022 09:44:06 +0200 Message-ID: Subject: Re: [PATCH] Improve sorry message for -fzero-call-used-regs To: =?UTF-8?Q?Torbj=C3=B6rn_SVENSSON?= Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, Sep 18, 2022 at 11:09 AM Torbj=C3=B6rn SVENSSON via Gcc-patches wrote: > > When the -fzero-call-used-regs command line option is used with an > unsupported value, indicate that it's a value problem instead of an > option problem. > > Without the patch, the error is: > In file included from gcc/testsuite/c-c++-common/zero-scratch-regs-8.c:5: > gcc/testsuite/c-c++-common/zero-scratch-regs-1.c: In function 'foo': > gcc/testsuite/c-c++-common/zero-scratch-regs-1.c:10:1: sorry, unimplement= ed: '-fzero-call-used-regs' not supported on this target > 10 | } > | ^ > > With the patch, the error would be like this: > In file included from gcc/testsuite/c-c++-common/zero-scratch-regs-8.c:5= : > gcc/testsuite/c-c++-common/zero-scratch-regs-1.c: In function 'foo': > gcc/testsuite/c-c++-common/zero-scratch-regs-1.c:10:1: sorry, unimplement= ed: Argument 'all-arg' is not supported for '-fzero-call-used-regs' on this= target the 'A' in 'Argument' should be lower case. Otherwise LGTM. Richard. > 10 | } > | ^ > > 2022-09-18 Torbj=C3=B6rn SVENSSON > > gcc/ChangeLog: > > * targhooks.cc (default_zero_call_used_regs): Improve sorry > message. > > Signed-off-by: Torbj=C3=B6rn SVENSSON > --- > gcc/targhooks.cc | 17 +++++++++++++++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > > diff --git a/gcc/targhooks.cc b/gcc/targhooks.cc > index b15ae19bcb6..8bfbc1d18f6 100644 > --- a/gcc/targhooks.cc > +++ b/gcc/targhooks.cc > @@ -93,6 +93,7 @@ along with GCC; see the file COPYING3. If not see > #include "gimple.h" > #include "cfgloop.h" > #include "tree-vectorizer.h" > +#include "options.h" > > bool > default_legitimate_address_p (machine_mode mode ATTRIBUTE_UNUSED, > @@ -1181,9 +1182,21 @@ default_zero_call_used_regs (HARD_REG_SET need_zer= oed_hardregs) > static bool issued_error; > if (!issued_error) > { > + const char *name =3D NULL; > + for (unsigned int i =3D 0; zero_call_used_regs_opts[i].name != =3D NULL; > + ++i) > + if (flag_zero_call_used_regs =3D=3D zero_call_used_regs_opts[= i].flag) > + { > + name =3D zero_call_used_regs_opts[i].name; > + break; > + } > + > + if (!name) > + name =3D ""; > + > issued_error =3D true; > - sorry ("%qs not supported on this target", > - "-fzero-call-used-regs"); > + sorry ("Argument %qs is not supported for %qs on this target", > + name, "-fzero-call-used-regs"); > } > } > > -- > 2.25.1 >