[PATCH] Change dump expectation in PR71857

[PATCH] Change dump expectation in PR71857

[Martin Liška]

[-- Attachment #1: Type: text/plain, Size: 209 bytes --]

Hello.

After changing the expected number of loop iterations, IVOPTS decides to pick up an another IV.
Bin agreed that the test-case still makes sense with changed expectation.

Ready to be installed?
Martin

[-- Attachment #2: 0001-Change-dump-expectation-in-PR71857.patch --]
[-- Type: text/x-patch, Size: 885 bytes --]

From 8073251d3827e0c7cd26680e97aa416e23132386 Mon Sep 17 00:00:00 2001
From: marxin <mliska@suse.cz>
Date: Mon, 1 Aug 2016 11:11:29 +0200
Subject: [PATCH] Change dump expectation in PR71857

gcc/testsuite/ChangeLog:

2016-08-01  Martin Liska  <mliska@suse.cz>

	* gcc.dg/tree-ssa/ivopt_mult_4.c: Change expectation.
---
 gcc/testsuite/gcc.dg/tree-ssa/ivopt_mult_4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/testsuite/gcc.dg/tree-ssa/ivopt_mult_4.c b/gcc/testsuite/gcc.dg/tree-ssa/ivopt_mult_4.c
index 8abccf8..effb052 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/ivopt_mult_4.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/ivopt_mult_4.c
@@ -21,4 +21,4 @@ long foo(long* p, long* p2, int N1, int N2)
   return s;
 }
 
-/* { dg-final { scan-tree-dump-times "Replacing" 0 "ivopts"} } */
+/* { dg-final { scan-tree-dump "Replacing exit test" "ivopts"} } */
-- 
2.9.2

Re: [PATCH] Change dump expectation in PR71857

[Richard Biener]

On Mon, Aug 1, 2016 at 1:30 PM, Martin Liška <mliska@suse.cz> wrote:
> Hello.
>
> After changing the expected number of loop iterations, IVOPTS decides to pick up an another IV.
> Bin agreed that the test-case still makes sense with changed expectation.
>
> Ready to be installed?

Hmm, but do all targets replace the exit test?  I think you want to
allow either no "Replacing"
or just "Replacing exit test" - not sure how to encode that in a regex.

Richard.

> Martin

Re: [PATCH] Change dump expectation in PR71857

[Martin Liška]

On 08/01/2016 01:58 PM, Richard Biener wrote:
> On Mon, Aug 1, 2016 at 1:30 PM, Martin Liška <mliska@suse.cz> wrote:
>> Hello.
>>
>> After changing the expected number of loop iterations, IVOPTS decides to pick up an another IV.
>> Bin agreed that the test-case still makes sense with changed expectation.
>>
>> Ready to be installed?
> 
> Hmm, but do all targets replace the exit test?  I think you want to
> allow either no "Replacing"
> or just "Replacing exit test" - not sure how to encode that in a regex.
> 
> Richard.

Well, the test-case is run just on { i?86-*-* x86_64-*-* } && lp64
with -m64, thus I guess the exit condition should be always replaced.

Martin


> 
>> Martin

Re: [PATCH] Change dump expectation in PR71857

[Richard Biener]

On Mon, Aug 1, 2016 at 2:12 PM, Martin Liška <mliska@suse.cz> wrote:
> On 08/01/2016 01:58 PM, Richard Biener wrote:
>> On Mon, Aug 1, 2016 at 1:30 PM, Martin Liška <mliska@suse.cz> wrote:
>>> Hello.
>>>
>>> After changing the expected number of loop iterations, IVOPTS decides to pick up an another IV.
>>> Bin agreed that the test-case still makes sense with changed expectation.
>>>
>>> Ready to be installed?
>>
>> Hmm, but do all targets replace the exit test?  I think you want to
>> allow either no "Replacing"
>> or just "Replacing exit test" - not sure how to encode that in a regex.
>>
>> Richard.
>
> Well, the test-case is run just on { i?86-*-* x86_64-*-* } && lp64
> with -m64, thus I guess the exit condition should be always replaced.

Ah, ok then.

Richard.

> Martin
>
>
>>
>>> Martin
>