From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by sourceware.org (Postfix) with ESMTPS id 7EE513846092 for ; Fri, 24 May 2024 12:33:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7EE513846092 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7EE513846092 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::232 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716554033; cv=none; b=Pr3qqJH6L5y0t830EFbnAOvhXmuItBI+LEDhpk0sbIxKoEMiV6lIGxLHl6NSrC/RwYUITbl4+2Rw5tJKfuNVQugvPerlv3ym9x0Tc9iOqpy/0FdmJ6wI0m7TKeKkbUIfFu2kBTg63ach3qkbuP+lHs/BB1SHezFprfR+WJLdjyo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716554033; c=relaxed/simple; bh=aZHYQ/H9Xm23WVPjcJVtvey7elgROaAI2LwXeekHrgs=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=UIiQsS6g1rR9NGZCnBMELTS83ZULsGlJxjTtUSQGwMtKHs5nFNx0stvhjSzMCqwdGaa8Z8DFgh7WRg30tizb8RGf64affxIErYteJXz3RDCz1UmcZspyVzCVaOHraMXso7d5/39Cyn2SsZxU4LUYuSlxLpHGbGGtAa77IDa2jUE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-2e576057c56so86690001fa.3 for ; Fri, 24 May 2024 05:33:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716554030; x=1717158830; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=bcd63Va9v4FSLqKI3ED3hb8DmakwEzd8UlDgEbIFqVc=; b=nRAtVs/10IIi6w1x3ALE9HR6bJNCd1DnoSI3ELRZwO9dlqvOCe79ey0i6zET/34wbT TE6GdE6vMCThONMr8bw8+tbQlVNq6kKlrbbCJGEAc0+qsIaLcJoE852tD3IKo3d+8QVz C5zFU+3pa1hff2iyvSvvhLyeQdrYJ51Y0AqWUv1CytVV6Trk16NlnOdGY7ITnN0vigiv /J9b/KPQSIBG8WYDJlJ1cMFQfV2yz3KdV0SKkY0kvqNDZj5YZonvMmzBcLeLrCAyLcQ0 tDPObTvlZSoE2aIDWV4gAQ38hc72Syt9SSoPr1SwxPwOSZK4rnMU5eG77lvS8XEkxARt fWwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716554030; x=1717158830; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bcd63Va9v4FSLqKI3ED3hb8DmakwEzd8UlDgEbIFqVc=; b=IC+Dov1Wu29KogfXR6DIHRfZCl86XBydZK35G3RVOu/PppVFJBcGF65I5sQDfYHIGl NLQEt3R8sOU8yEcGclDysadQT56CATUO7Sj8C3ubgROfroH76cVkGqz/7/hx4+vdcuO2 14rGWrkV2QYkH7q9exi8CQp88txw2bvc0wzBX331rxSoVgjGFz68HtTIIvwsr119lJ2G EPCSxBZsR3uoFou7wUT5Bv3t2OSRHQv4OaP4QDjG/wnXkvyLZkOuUdZnGxt/euGYuF7O pCucroW1d514qpy5oE0T02ivEo/uUP6c/Ql2KfFzXmpt7RY01tQViuwM6+wG8DPRq2iz 9UYg== X-Gm-Message-State: AOJu0YxmQV3kJf9hmIRFQkYbMziiBxdvOi6mo/qX22/BQ/ECNTZ/EN2y hlEAKecVDLXdrcA+2o9KzTNuxSEV5anIgV7aHmQABY0EhoF++0Nnu2xxLsFReOEsEA2q3Yj8Yun q4R22KBAqzVtbfk3s0pu3xuHxZTo= X-Google-Smtp-Source: AGHT+IH+fdZwCBOLScXK7PlDJ4snzZunXytsm+kKDoAiF4h3PJcYKJHlS9Ux5qky5YZZuFuR33lvGCzdZ9Ve42OD0b8= X-Received: by 2002:a05:6512:2e6:b0:516:e8b1:9ed5 with SMTP id 2adb3069b0e04-52966bad06bmr1198835e87.59.1716554029520; Fri, 24 May 2024 05:33:49 -0700 (PDT) MIME-Version: 1.0 References: <20240524114826.1453659-1-jiawei@iscas.ac.cn> In-Reply-To: <20240524114826.1453659-1-jiawei@iscas.ac.cn> From: Richard Biener Date: Fri, 24 May 2024 14:33:38 +0200 Message-ID: Subject: Re: [PATCH] tree-ssa-pre.c/1071140(ICE in find_or_generate_expression, at tree-ssa-pre.c:2780): Return NULL_TREE if no equal. To: Jiawei , Richard Sandiford Cc: gcc-patches@gcc.gnu.org, kito.cheng@gmail.com, jlaw@ventanamicro.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, May 24, 2024 at 1:49=E2=80=AFPM Jiawei wrote: > > An ICE bug reported in > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D1071140. > https://godbolt.org/z/WE9aGYvoo > > Return NULL_TREE when TREE_CODE(op) not equal to SSA_NAME. The assert is on purpose. Can you open a GCC bug for this please? It look= s like we have unfolded POLY_INT_CST [16, 16] /[ex] 16 here. It seems that /* We can't always put a size in units of the element alignment here as the element alignment may be not visible. See PR43783. Simply drop the element size for constant sizes. */ if (TREE_CODE (genop3) =3D=3D INTEGER_CST && TREE_CODE (TYPE_SIZE_UNIT (elmt_type)) =3D=3D INTEGER_CS= T && wi::eq_p (wi::to_offset (TYPE_SIZE_UNIT (elmt_type)), (wi::to_offset (genop3) * vn_ref_op_align_unit (currop)))) genop3 =3D NULL_TREE; fails to match the POLY_INT case - the unit alignment is 16 here. One possibility would be to match the EXACT_DIV_EXPR case and the INTEGER_CST divisor to vn_ref_op_align_unit and the other half separately. But maybe this can be written in a "proper" way? The EXACT_DIV_EXPR is built by copy_reference_ops_from_ref, I suppose SVE could be similarly affected. Richard. > gcc/ChangeLog: > > * tree-ssa-pre.cc (find_or_generate_expression): Remove assert. > > gcc/testsuite/ChangeLog: > > * gcc.target/riscv/rvv/vsetvl/pr1071140.c: New test. > > --- > .../gcc.target/riscv/rvv/vsetvl/pr1071140.c | 52 +++++++++++++++++++ > gcc/tree-ssa-pre.cc | 4 +- > 2 files changed, 55 insertions(+), 1 deletion(-) > create mode 100644 gcc/testsuite/gcc.target/riscv/rvv/vsetvl/pr1071140.c > > diff --git a/gcc/testsuite/gcc.target/riscv/rvv/vsetvl/pr1071140.c b/gcc/= testsuite/gcc.target/riscv/rvv/vsetvl/pr1071140.c > new file mode 100644 > index 00000000000..4f0815e099f > --- /dev/null > +++ b/gcc/testsuite/gcc.target/riscv/rvv/vsetvl/pr1071140.c > @@ -0,0 +1,52 @@ > +/* { dg-do compile } */ > +/* { dg-options "-mrvv-vector-bits=3Dscalable -march=3Drv64gcv -mabi=3Dl= p64d -O3 -w" } */ > + > +#include > + > +static inline __attribute__(()) int vaddq_f32(); > +static inline __attribute__(()) int vload_tillz_f32(int nlane) { > + vint32m1_t __trans_tmp_9; > + { > + int __trans_tmp_0 =3D nlane; > + { > + vint64m1_t __trans_tmp_1; > + vint64m1_t __trans_tmp_2; > + vint64m1_t __trans_tmp_3; > + vint64m1_t __trans_tmp_4; > + if (__trans_tmp_0 =3D=3D 1) { > + { > + __trans_tmp_3 =3D > + __riscv_vslideup_vx_i64m1(__trans_tmp_1, __trans_tmp_2, 1,= 2); > + } > + __trans_tmp_4 =3D __trans_tmp_2; > + } > + __trans_tmp_4 =3D __trans_tmp_3; > + __trans_tmp_9 =3D __riscv_vreinterpret_v_i64m1_i32m1(__trans_tmp_3= ); > + } > + } > + return vaddq_f32(__trans_tmp_9); /* { dg-error {RVV type 'vint32m1_t' = cannot be passed to an unprototyped function} } */ > +} > + > +char CFLOAT_add_args[3]; > +const int *CFLOAT_add_steps; > +const int CFLOAT_steps; > + > +__attribute__(()) void CFLOAT_add() { > + char *b_src0 =3D &CFLOAT_add_args[0], *b_src1 =3D &CFLOAT_add_args[1], > + *b_dst =3D &CFLOAT_add_args[2]; > + const float *src1 =3D (float *)b_src1; > + float *dst =3D (float *)b_dst; > + const int ssrc1 =3D CFLOAT_add_steps[1] / sizeof(float); > + const int sdst =3D CFLOAT_add_steps[2] / sizeof(float); > + const int hstep =3D 4 / 2; > + vfloat32m1x2_t a; > + int len =3D 255; > + for (; len > 0; len -=3D hstep, src1 +=3D 4, dst +=3D 4) { > + int b =3D vload_tillz_f32(len); > + int r =3D vaddq_f32(a.__val[0], b); /* { dg-error {RVV type '__rvv_f= loat32m1_t' cannot be passed to an unprototyped function} } */ > + } > + for (; len > 0; --len, b_src0 +=3D CFLOAT_steps, > + b_src1 +=3D CFLOAT_add_steps[1], b_dst +=3D CFLOAT_add= _steps[2]) > + ; > +} > + > diff --git a/gcc/tree-ssa-pre.cc b/gcc/tree-ssa-pre.cc > index 75217f5cde1..e3d9c47f96b 100644 > --- a/gcc/tree-ssa-pre.cc > +++ b/gcc/tree-ssa-pre.cc > @@ -2777,7 +2777,9 @@ find_or_generate_expression (basic_block block, tre= e op, gimple_seq *stmts) > if (is_gimple_min_invariant (op)) > return op; > > - gcc_assert (TREE_CODE (op) =3D=3D SSA_NAME); > + if (TREE_CODE (op) !=3D SSA_NAME) > + return NULL_TREE; > + > vn_ssa_aux_t info =3D VN_INFO (op); > unsigned int lookfor =3D info->value_id; > if (value_id_constant_p (lookfor)) > -- > 2.25.1 >