From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by sourceware.org (Postfix) with ESMTPS id A5D6E38358BF for ; Thu, 15 Dec 2022 08:20:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A5D6E38358BF Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-x22d.google.com with SMTP id h10so9149204ljk.11 for ; Thu, 15 Dec 2022 00:20:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=L3/yfpmoFXTa1DgezOKxsrrm2BxTC5SxxGwXHHCjwa0=; b=FR2W7WiOJkd6zsN0f5W5fA6L7LQVg9MmledIo2TFGwJfrTbwx9J68ISlarqydkQAVm xP5UBMPz1XzVqQhNHjbvva47NVAhH3eR1YWAkV+H5iNSrP8BRCi74QZBdxVpnPOmUk4w MX5uIZva3u6DzIuOZ+roWZ6tRWIDZINmZuyWpt804LDJxtwXdBCPlKG5nNZbSNEh9kH1 RW/u3AE3EB7FAKzQXWtg5PTcYpAijBWJ8sklQFhaTGjy6CWWmxns/WYeXtDO5J1poF4P qAFmU7GSrT4B9qXQQ5VmHzydxhv3pbcO7gVxrQWJqgpEI0fMj5NBhRA9P2B7+nX/CObs fjSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=L3/yfpmoFXTa1DgezOKxsrrm2BxTC5SxxGwXHHCjwa0=; b=kD5t4O/IvZVn0Fsc/ua4EhWhxyOGv1OFBLKNDm2J/8tbsDWnMGrLF/nPF0uulKEK1O ud1x8sU7FC9lD3vRDLHlZui8Ydl0st6Z+cv4Y8Ewc8yHD3wMFkiktX1YQZ66RLZMFfHY 6PL/Q+ba0JDGTb2YsK9GgJdq8Qzx9qb4QGTZQ/Sibq/RFvf1tHJ2EaRTep/VyJKxHyKR Qo0LCLQDa8C91w15aUASG2qE1B2PjwbvJOyun55tOGeVm97/OluW2XBLw+A9tAACcmaS WX/EvtDGocz1lKGCIOTKryYdyLUBw8eDRQLti5zRTV7JNhrKVaI5H79HU3B4u1dR03CQ 59rQ== X-Gm-Message-State: ANoB5pmTwha9pdbloaIglaijL7UHpG7fvu8TlRLVsq5+gr/8ZfswHlqN NzbjBSDVfWXQHwmVY0idP3fMgpQHkPu2187fBZo= X-Google-Smtp-Source: AA0mqf4Xx8Jv7IZG5m7eca4B0cKyK0uG2rzEx68N6+T/Hcd2XL5bH+3j5+XOAXfc0NDBlUq6z3jS7GLZfUaV212rL1w= X-Received: by 2002:a05:651c:2108:b0:27b:4c18:4827 with SMTP id a8-20020a05651c210800b0027b4c184827mr722629ljq.448.1671092444984; Thu, 15 Dec 2022 00:20:44 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Richard Biener Date: Thu, 15 Dec 2022 09:20:32 +0100 Message-ID: Subject: Re: [PATCH] ipa-sra: Consider the first parameter of methods safe to dereference To: Jan Hubicka Cc: Martin Jambor , GCC Patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Dec 14, 2022 at 4:20 PM Jan Hubicka via Gcc-patches wrote: > > > Hi, > > > > Honza requested this after reviewing the patch that taught IPA-SRA > > that REFERENCE_TYPEs are always non-NULL that the pass also handles > > the first parameters of methods, this pointers, in the same way. So > > this patch does that. > > > > The patch is undergoing bootstrap and testing on an x86_64-linux right > > now. OK if it passes? > > > > Thanks, > > > > Martin > > > > > > gcc/ChangeLog: > > > > 2022-12-14 Martin Jambor > > > > * ipa-sra.cc (create_parameter_descriptors): Consider the first > > parameter of a method safe to dereference. > > > > gcc/testsuite/ChangeLog: > > > > 2022-12-14 Martin Jambor > > > > * g++.dg/ipa/ipa-sra-6.C: New test. > > OK, Are you sure that's safe? The docs for METHOD_TYPE doesn't say 'this' is the first parameter nor does it say methods cannot be invoked for a nullptr object. Do frontends other than C++ create METHOD_TYPE functions? Grep shows uses in ada and objective C at least. > thanks a lot! > Honza