From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by sourceware.org (Postfix) with ESMTPS id 69CB93858D38 for ; Tue, 11 Apr 2023 08:47:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 69CB93858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-x12f.google.com with SMTP id i26so9784679lfc.6 for ; Tue, 11 Apr 2023 01:47:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1681202838; x=1683794838; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=SXOiQjRUviqGKoVFl6lZ4d09gSMJkZJlvboC1N4IfH0=; b=pMf5uAw4QBraKkgztFtxG/BRCw6BGIXav4Vc7+OpkDRPpCvKh4+g2C3lO6WPuH3g6A EiFSoAv8QBXIGaNcZ04HfNGoRwBdBy8OS8Mqgz5y0r+S+N6cyh5XfGUfFxQ6ZD1hV5iy 3oH2oTZoH8adbOBRVNtbXOyvZMiGytaAkN7w3rh6SReHRD/+lHhT8GI0K7aBSEQMbb2T ZmPbm1v0nxvUA/6p3mEgKl38gQtyscUg08vyFewa3g8M+2Pd3agsc0xfxbdpxUTBOhHz KqcVGCTIZQ7wvQRDfH+PzGAb5sasFEL2xq3D+G/DzNH+wi4zYGiOAcS/7kJMIGbQTJa6 WU/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681202838; x=1683794838; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SXOiQjRUviqGKoVFl6lZ4d09gSMJkZJlvboC1N4IfH0=; b=zlSS49IK9j/OO8Uu2xI5qIbPQAhUhDiiIWG8X2os+4FMt4ebnfov2wigi8G2ubTMK6 t25ipyHPCf+9N3p9oeICSDChVr6bzf8echC70S6hZNziO9vCD/hd2vRW9jJBZ0UZ7tF/ vdju1pQMJqjK2bzB2cCoC6WoXtw/bzv5SrBhzGwzW9wYMvcw6ZccRKNlwn1GlzK/+yYc v2DZ6awS3HiA3LfEHAiwnJ4nU60idtwfm4LZbiWuDl5u46Xigy+bdWiHMTScGNbpRkhg HnCo0ccme/tlDMsGwofnItijQ0SPuhMVY4HCIWT8cm8A9jtH7/IZs7rI7LQ7UABPlhwg LWOw== X-Gm-Message-State: AAQBX9f7nqbKPj3QiHF4FDZ+PCf9W5wsVaHPaLkOPFN86fpQ5CGXH30G 3sxJpQ2xguMPvFtg0mqIYKE6gdluZCooDsJMRcg= X-Google-Smtp-Source: AKy350b9Lilrf71O4mBmaomBSvvYjzEC9mmeVkdyEvju2ngYuShSVJn6rTuOyd0MNR2fbRY9h9zwie2Mom3j37uOMGY= X-Received: by 2002:ac2:50c3:0:b0:4eb:2643:d202 with SMTP id h3-20020ac250c3000000b004eb2643d202mr3645878lfm.12.1681202838450; Tue, 11 Apr 2023 01:47:18 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Richard Biener Date: Tue, 11 Apr 2023 10:46:22 +0200 Message-ID: Subject: Re: [match.pd] [SVE] Add pattern to transform svrev(svrev(v)) --> v To: Prathamesh Kulkarni Cc: gcc Patches , Richard Sandiford Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Apr 5, 2023 at 10:39=E2=80=AFAM Prathamesh Kulkarni via Gcc-patches wrote: > > Hi, > For the following test: > > svint32_t f(svint32_t v) > { > return svrev_s32 (svrev_s32 (v)); > } > > We generate 2 rev instructions instead of nop: > f: > rev z0.s, z0.s > rev z0.s, z0.s > ret > > The attached patch tries to fix that by trying to recognize the following > pattern in match.pd: > v1 =3D VEC_PERM_EXPR (v0, v0, mask) > v2 =3D VEC_PERM_EXPR (v1, v1, mask) > --> > v2 =3D v0 > if mask is { nelts - 1, nelts - 2, nelts - 3, ... } > > Code-gen with patch: > f: > ret > > Bootstrap+test passes on aarch64-linux-gnu, and SVE bootstrap in progress= . > Does it look OK for stage-1 ? I didn't look at the patch but tree-ssa-forwprop.cc:simplify_permutation sh= ould handle two consecutive permutes with the is_combined_permutation_identity which might need tweaking for VLA vectors Richard. > > Thanks, > Prathamesh