From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51234 invoked by alias); 29 Apr 2015 09:02:55 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 51224 invoked by uid 89); 29 Apr 2015 09:02:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oi0-f44.google.com Received: from mail-oi0-f44.google.com (HELO mail-oi0-f44.google.com) (209.85.218.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 29 Apr 2015 09:02:53 +0000 Received: by oica37 with SMTP id a37so16563612oic.0 for ; Wed, 29 Apr 2015 02:02:51 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.202.71.84 with SMTP id u81mr16756547oia.81.1430298171922; Wed, 29 Apr 2015 02:02:51 -0700 (PDT) Received: by 10.76.115.167 with HTTP; Wed, 29 Apr 2015 02:02:51 -0700 (PDT) In-Reply-To: <55409BDD.8070305@mentor.com> References: <55409BDD.8070305@mentor.com> Date: Wed, 29 Apr 2015 09:25:00 -0000 Message-ID: Subject: Re: [PATCH][PR65893] Move pass_stdarg to after pass_dce in pass_all_optimizations From: Richard Biener To: Tom de Vries Cc: GCC Patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg01841.txt.bz2 On Wed, Apr 29, 2015 at 10:52 AM, Tom de Vries wrote: > Hi, > > After moving the expansion of va_arg from gimplification to pass_stdarg, we > execute less optimization passes on the expanded va_arg. > > For example, in PR65893 the optimized-dump code for a va_arg expansion for > aarch64 is less optimal than it was before, because pass_tree_ifcombine is > no longer executed for the expanded va_arg. > > This patch fixes the problem by moving pass_stdarg a bit earlier, to after > pass_dce: > ... > NEXT_PASS (pass_vrp); > NEXT_PASS (pass_chkp_opt); > NEXT_PASS (pass_dce); > + NEXT_PASS (pass_stdarg); > NEXT_PASS (pass_call_cdce); > NEXT_PASS (pass_cselim); > NEXT_PASS (pass_copy_prop); > NEXT_PASS (pass_tree_ifcombine); > NEXT_PASS (pass_phiopt); > NEXT_PASS (pass_tail_recursion); > NEXT_PASS (pass_ch); > - NEXT_PASS (pass_stdarg); > NEXT_PASS (pass_lower_complex); > NEXT_PASS (pass_sra); > NEXT_PASS (pass_rename_ssa_copies); > ... > > Bootstrapped and reg-tested on x86_64. > > OK for trunk? Ok. Thanks, Richard. > Thanks, > - Tom