From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14246 invoked by alias); 9 Jan 2014 15:20:06 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 14233 invoked by uid 89); 9 Jan 2014 15:20:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wg0-f41.google.com Received: from mail-wg0-f41.google.com (HELO mail-wg0-f41.google.com) (74.125.82.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 09 Jan 2014 15:20:05 +0000 Received: by mail-wg0-f41.google.com with SMTP id y10so6063411wgg.0 for ; Thu, 09 Jan 2014 07:20:01 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.180.104.42 with SMTP id gb10mr26907398wib.51.1389280801888; Thu, 09 Jan 2014 07:20:01 -0800 (PST) Received: by 10.194.243.105 with HTTP; Thu, 9 Jan 2014 07:20:01 -0800 (PST) In-Reply-To: <5C2EC229-6322-4263-B4FE-6C06EEC946A9@comcast.net> References: <5C2EC229-6322-4263-B4FE-6C06EEC946A9@comcast.net> Date: Thu, 09 Jan 2014 15:20:00 -0000 Message-ID: Subject: Re: wide-int, ipa From: Richard Biener To: Mike Stump Cc: "gcc-patches@gcc.gnu.org Patches" , Kenneth Zadeck Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00503.txt.bz2 On Thu, Jan 2, 2014 at 5:12 AM, Mike Stump wrote: > On Nov 23, 2013, at 11:22 AM, Mike Stump wrote: >> Richi has asked the we break the wide-int patch so that the individual port and front end maintainers can review their parts without have to go through the entire patch. This patch covers the ipa code. >> >> Ok? > > Ping? > > I promise, this patch isn't frightening. Small, easy to read and understand, doesn't require an ipa expert. Why @@ -968,7 +968,7 @@ get_polymorphic_call_info (tree fndecl, { base_pointer = TREE_OPERAND (base, 0); context->offset - += offset2 + mem_ref_offset (base).low * BITS_PER_UNIT; + += offset2 + mem_ref_offset (base).ulow () * BITS_PER_UNIT; context->outer_type = NULL; } /* We found base object. In this case the outer_type but then @@ -1063,7 +1063,7 @@ compute_complex_assign_jump_func (struct ipa_node_params *info, || max_size == -1 || max_size != size) return; - offset += mem_ref_offset (base).low * BITS_PER_UNIT; + offset += mem_ref_offset (base).to_short_addr () * BITS_PER_UNIT; ssa = TREE_OPERAND (base, 0); if (TREE_CODE (ssa) != SSA_NAME || !SSA_NAME_IS_DEFAULT_DEF (ssa) ? I think it should be to_short_addr () in the first case as well. Ok with that change. Richard. >