From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <richard.guenther@gmail.com>
Received: from mail-qv1-xf31.google.com (mail-qv1-xf31.google.com
 [IPv6:2607:f8b0:4864:20::f31])
 by sourceware.org (Postfix) with ESMTPS id B8EA33858D3C
 for <gcc-patches@gcc.gnu.org>; Wed, 18 May 2022 05:57:25 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B8EA33858D3C
Received: by mail-qv1-xf31.google.com with SMTP id ej7so783217qvb.13
 for <gcc-patches@gcc.gnu.org>; Tue, 17 May 2022 22:57:25 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=qOElnNYszeDhxyDSM0/RwdiwbcIstsR2xlY+tdhSEO0=;
 b=NQilkkv+Yrb0XsoG76DGhlQlk6/2qxl+Ye04VBe711c3VI6h+NFTqQJPs3eP3zI08U
 0BRS9dizPBA0bizKs1f3oN2tHht0OUTZf87HxW9CbwdsdCUWBWogk5Tk/PG/papHL6Eh
 LJFaxUT8FL6KECc2aVIYPTanE7I55IM32JeKI0N4++qEGCc7kd6e1To3jbFegWFtaG9c
 4AiIoaJDEvMwpuJfd4SWzSl9y3m2wLn6NW5TkR10pNAok2Urbz941PpI/QfgD+3WEnqU
 O2O61sNBIHM3rogH1cuBjPtFX/NQm+gG6qeS/NeH5jrtId2aLm46PnQkac4z1dIdEMqj
 GeiA==
X-Gm-Message-State: AOAM53129EWgzGzAXKyWVrdn0mbBYxR2cqT+/KClLfBOJnsiZkmvuwTR
 4AzgLZIyeNyWE/N0WleuSLjRyzglkHEjOs/BSFY=
X-Google-Smtp-Source: ABdhPJw6QaR0NelUg4w4Izj7TyyhBjld2+UWvVrc+4drS04p5dqRAbG6uICBMP4FIan8zREwpH5wd16/m5jODX5aVD4=
X-Received: by 2002:ad4:5ec5:0:b0:45a:e385:d436 with SMTP id
 jm5-20020ad45ec5000000b0045ae385d436mr23221989qvb.78.1652853444561; Tue, 17
 May 2022 22:57:24 -0700 (PDT)
MIME-Version: 1.0
References: <df503963-2b9d-cc87-ece9-e85ca0766ed6@redhat.com>
In-Reply-To: <df503963-2b9d-cc87-ece9-e85ca0766ed6@redhat.com>
From: Richard Biener <richard.guenther@gmail.com>
Date: Wed, 18 May 2022 07:57:13 +0200
Message-ID: <CAFiYyc18KQjw_CKUMMKjSNydugx+UfNyMutY0Us3EWcS8o_CFg@mail.gmail.com>
Subject: Re: [PATCH] PR tree-optimization/105458 - Check for equivalence after
 merging relations.
To: Andrew MacLeod <amacleod@redhat.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 18 May 2022 05:57:27 -0000

On Tue, May 17, 2022 at 5:46 PM Andrew MacLeod via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> Sorry, missed this one earlier.
>
> When we register a relation, such as LE_EXPR,  we first check if there
> is an existing relation that applies, and if so they are combined. We
> were checking if the relation being registered was an EQ_EXPR, and if
> so, invoked the equivalence oracle.
>
>   I was doing the check for EQ_EXPR first, then merging with any
> existing relation.   In this case, the merge resulted in transforming
> the LE_EXPR into an EQ_EXPR, but the check to invoke the
> equivalence_oracle had already been done, and we got to a place we
> shouldn't have. doh!
>
> The fix is to do the merge first, then check for EQ_EXPR.
>
> The patch is a hair different (due to VREL_*  renames in gcc13), so I've
> attached both patches.
>
> bootstraps on gcc12 and gcc13 with no regressions.  pushed on trunk.
>
> OK for GCC12?

OK

> Andrew