public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Biener <richard.guenther@gmail.com>
To: "Kewen.Lin" <linkw@linux.ibm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
	j@lambda.is,  Peter Bergner <bergner@linux.ibm.com>,
	Segher Boessenkool <segher@kernel.crashing.org>
Subject: Re: [PATCH] testsuite: Add profile_update_atomic check to gcov-20.c [PR114614]
Date: Mon, 8 Apr 2024 12:47:42 +0200	[thread overview]
Message-ID: <CAFiYyc18Pmk_s03xaBrYUEF4ShcGL4L-P1MB0Tg0OU7eHhaxYA@mail.gmail.com> (raw)
In-Reply-To: <dae0f576-85fd-4955-5cec-256e08e43ae7@linux.ibm.com>

On Mon, Apr 8, 2024 at 11:23 AM Kewen.Lin <linkw@linux.ibm.com> wrote:
>
> Hi,
>
> As PR114614 shows, the newly added test case gcov-20.c by
> commit r14-9789-g08a52331803f66 failed on targets which do
> not support atomic profile update, there would be a message
> like:
>
>   warning: target does not support atomic profile update,
>            single mode is selected
>
> Since the test case adopts -fprofile-update=atomic, it
> requires effective target check profile_update_atomic, this
> patch is to add the check accordingly.
>
> Tested well on x86_64-redhat-linux, powerpc64-linux-gnu P8/P9
> and powerpc64le-linux-gnu P9/P10.
>
> Is it ok for trunk?

OK

> BR,
> Kewen
> -----
>         PR testsuite/114614
>
> gcc/testsuite/ChangeLog:
>
>         * gcc.misc-tests/gcov-20.c: Add effective target check
>         profile_update_atomic.
> ---
>  gcc/testsuite/gcc.misc-tests/gcov-20.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gcc/testsuite/gcc.misc-tests/gcov-20.c b/gcc/testsuite/gcc.misc-tests/gcov-20.c
> index 215faffc980..ca8c12aad2b 100644
> --- a/gcc/testsuite/gcc.misc-tests/gcov-20.c
> +++ b/gcc/testsuite/gcc.misc-tests/gcov-20.c
> @@ -1,5 +1,6 @@
>  /* { dg-options "-fcondition-coverage -ftest-coverage -fprofile-update=atomic" } */
>  /* { dg-do run { target native } } */
> +/* { dg-require-effective-target profile_update_atomic } */
>
>  /* Some side effect to stop branches from being pruned */
>  int x = 0;
> --
> 2.43.0

  reply	other threads:[~2024-04-08 10:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-08  9:23 Kewen.Lin
2024-04-08 10:47 ` Richard Biener [this message]
2024-04-09  2:07   ` Kewen.Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFiYyc18Pmk_s03xaBrYUEF4ShcGL4L-P1MB0Tg0OU7eHhaxYA@mail.gmail.com \
    --to=richard.guenther@gmail.com \
    --cc=bergner@linux.ibm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=j@lambda.is \
    --cc=linkw@linux.ibm.com \
    --cc=segher@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).