* [PATCH] testsuite: Add profile_update_atomic check to gcov-20.c [PR114614]
@ 2024-04-08 9:23 Kewen.Lin
2024-04-08 10:47 ` Richard Biener
0 siblings, 1 reply; 3+ messages in thread
From: Kewen.Lin @ 2024-04-08 9:23 UTC (permalink / raw)
To: GCC Patches; +Cc: Richard Biener, j, Peter Bergner, Segher Boessenkool
Hi,
As PR114614 shows, the newly added test case gcov-20.c by
commit r14-9789-g08a52331803f66 failed on targets which do
not support atomic profile update, there would be a message
like:
warning: target does not support atomic profile update,
single mode is selected
Since the test case adopts -fprofile-update=atomic, it
requires effective target check profile_update_atomic, this
patch is to add the check accordingly.
Tested well on x86_64-redhat-linux, powerpc64-linux-gnu P8/P9
and powerpc64le-linux-gnu P9/P10.
Is it ok for trunk?
BR,
Kewen
-----
PR testsuite/114614
gcc/testsuite/ChangeLog:
* gcc.misc-tests/gcov-20.c: Add effective target check
profile_update_atomic.
---
gcc/testsuite/gcc.misc-tests/gcov-20.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/gcc/testsuite/gcc.misc-tests/gcov-20.c b/gcc/testsuite/gcc.misc-tests/gcov-20.c
index 215faffc980..ca8c12aad2b 100644
--- a/gcc/testsuite/gcc.misc-tests/gcov-20.c
+++ b/gcc/testsuite/gcc.misc-tests/gcov-20.c
@@ -1,5 +1,6 @@
/* { dg-options "-fcondition-coverage -ftest-coverage -fprofile-update=atomic" } */
/* { dg-do run { target native } } */
+/* { dg-require-effective-target profile_update_atomic } */
/* Some side effect to stop branches from being pruned */
int x = 0;
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] testsuite: Add profile_update_atomic check to gcov-20.c [PR114614]
2024-04-08 9:23 [PATCH] testsuite: Add profile_update_atomic check to gcov-20.c [PR114614] Kewen.Lin
@ 2024-04-08 10:47 ` Richard Biener
2024-04-09 2:07 ` Kewen.Lin
0 siblings, 1 reply; 3+ messages in thread
From: Richard Biener @ 2024-04-08 10:47 UTC (permalink / raw)
To: Kewen.Lin; +Cc: GCC Patches, j, Peter Bergner, Segher Boessenkool
On Mon, Apr 8, 2024 at 11:23 AM Kewen.Lin <linkw@linux.ibm.com> wrote:
>
> Hi,
>
> As PR114614 shows, the newly added test case gcov-20.c by
> commit r14-9789-g08a52331803f66 failed on targets which do
> not support atomic profile update, there would be a message
> like:
>
> warning: target does not support atomic profile update,
> single mode is selected
>
> Since the test case adopts -fprofile-update=atomic, it
> requires effective target check profile_update_atomic, this
> patch is to add the check accordingly.
>
> Tested well on x86_64-redhat-linux, powerpc64-linux-gnu P8/P9
> and powerpc64le-linux-gnu P9/P10.
>
> Is it ok for trunk?
OK
> BR,
> Kewen
> -----
> PR testsuite/114614
>
> gcc/testsuite/ChangeLog:
>
> * gcc.misc-tests/gcov-20.c: Add effective target check
> profile_update_atomic.
> ---
> gcc/testsuite/gcc.misc-tests/gcov-20.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/gcc/testsuite/gcc.misc-tests/gcov-20.c b/gcc/testsuite/gcc.misc-tests/gcov-20.c
> index 215faffc980..ca8c12aad2b 100644
> --- a/gcc/testsuite/gcc.misc-tests/gcov-20.c
> +++ b/gcc/testsuite/gcc.misc-tests/gcov-20.c
> @@ -1,5 +1,6 @@
> /* { dg-options "-fcondition-coverage -ftest-coverage -fprofile-update=atomic" } */
> /* { dg-do run { target native } } */
> +/* { dg-require-effective-target profile_update_atomic } */
>
> /* Some side effect to stop branches from being pruned */
> int x = 0;
> --
> 2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] testsuite: Add profile_update_atomic check to gcov-20.c [PR114614]
2024-04-08 10:47 ` Richard Biener
@ 2024-04-09 2:07 ` Kewen.Lin
0 siblings, 0 replies; 3+ messages in thread
From: Kewen.Lin @ 2024-04-09 2:07 UTC (permalink / raw)
To: Richard Biener; +Cc: GCC Patches, j, Peter Bergner, Segher Boessenkool
on 2024/4/8 18:47, Richard Biener wrote:
> On Mon, Apr 8, 2024 at 11:23 AM Kewen.Lin <linkw@linux.ibm.com> wrote:
>>
>> Hi,
>>
>> As PR114614 shows, the newly added test case gcov-20.c by
>> commit r14-9789-g08a52331803f66 failed on targets which do
>> not support atomic profile update, there would be a message
>> like:
>>
>> warning: target does not support atomic profile update,
>> single mode is selected
>>
>> Since the test case adopts -fprofile-update=atomic, it
>> requires effective target check profile_update_atomic, this
>> patch is to add the check accordingly.
>>
>> Tested well on x86_64-redhat-linux, powerpc64-linux-gnu P8/P9
>> and powerpc64le-linux-gnu P9/P10.
>>
>> Is it ok for trunk?
>
> OK
Thanks, pushed as r14-9851.
BR,
Kewen
>
>> BR,
>> Kewen
>> -----
>> PR testsuite/114614
>>
>> gcc/testsuite/ChangeLog:
>>
>> * gcc.misc-tests/gcov-20.c: Add effective target check
>> profile_update_atomic.
>> ---
>> gcc/testsuite/gcc.misc-tests/gcov-20.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/gcc/testsuite/gcc.misc-tests/gcov-20.c b/gcc/testsuite/gcc.misc-tests/gcov-20.c
>> index 215faffc980..ca8c12aad2b 100644
>> --- a/gcc/testsuite/gcc.misc-tests/gcov-20.c
>> +++ b/gcc/testsuite/gcc.misc-tests/gcov-20.c
>> @@ -1,5 +1,6 @@
>> /* { dg-options "-fcondition-coverage -ftest-coverage -fprofile-update=atomic" } */
>> /* { dg-do run { target native } } */
>> +/* { dg-require-effective-target profile_update_atomic } */
>>
>> /* Some side effect to stop branches from being pruned */
>> int x = 0;
>> --
>> 2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-09 2:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-08 9:23 [PATCH] testsuite: Add profile_update_atomic check to gcov-20.c [PR114614] Kewen.Lin
2024-04-08 10:47 ` Richard Biener
2024-04-09 2:07 ` Kewen.Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).