From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by sourceware.org (Postfix) with ESMTPS id 8787B3858C39 for ; Mon, 8 Apr 2024 10:47:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8787B3858C39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8787B3858C39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::22c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712573277; cv=none; b=BIPpMdwoRDurSS7T9Tho7mvtNj2ZTlz+a5NQjOVsKWbcLYo3aAwN/48YbWtiVoGE/pIfJFW5yZT07IvlthQHcVRSyN0bn6dkFa+aajzjSpVPacNBeqVls6HrclS3xXr2bx8iA6aNVidrQgG3Scv8Hm1n+TPj7WW/cmUMrpUUnX0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712573277; c=relaxed/simple; bh=OTO/6iz+5faKKoVLpto/Y16RRvqfLzDJ12AD7Dx6Rc0=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=KJs+vcGpKnYCcNFkaZqVkbFOoFlUDSjAZo8XK1gnU90h4e+zV1wi1250s472TNVxOU/YNe/ZVErVPOvRAql+R+M60LEgbR/fdJw77Q6fwjFgVFTvHm4NMgMCK0/ENGndPPlgPC908EflxJ/VX+lhDtVoXXEbFB9RJnkOLalzUoA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-2d8129797fcso58158201fa.1 for ; Mon, 08 Apr 2024 03:47:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712573273; x=1713178073; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=k559tDSyOLM2DsoKN/AEj8QLhRgZN7Sg8ZN17a1801g=; b=WG6o0rJbm9tdoOXcUPSLNhK429FKA8Rf10rqtR9BQozdVdt8gSkhGr3ysIczRRh3kE WTGcfdsq8A3EfvJlLe+Dv8Ud2dXG4UyOkW8kwgkgkWLBP6r8kHtRF9lfI8ccE5PdPEp/ B/JivVT0ZLNgZs6GxazBoztOICRpoBjiwPkr1RLNDfTfj8eBTSI+/qF5teKgnKuVOYqu hGvYEntm4v+o99I5nGbcGkGlmIFnUib8b2dOjUfCLh1utRSFA3gB8oj2s6VTw9qKOPcJ yUyOJtS3HsKKHPAFuMW4MFL8ONc5/YRvqt1U5V0b7OeLWA7N4O8WGiq5PoB45z6EQi46 qWgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712573273; x=1713178073; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k559tDSyOLM2DsoKN/AEj8QLhRgZN7Sg8ZN17a1801g=; b=LnKqeAwxokyTauwk+2+/FHX0oRYQPleFIJTNoKo8/J2bCYam/6aLDJJPH62Ep2IKcm P4Q0DVh0ryc5Wz1Ka8BYtNxSjlJX2J65yuda1esyPsTWFiG83O8GeJ+L70DPV/6RrY1L s8QEJq18TGUgwPwxBHAdFCwaxaSs9hszSqGiK9O8pPwQmR8iw6yxUTlq3KTORbdU7JVd pZmBLULLFkrZvqePoHQT4MXfyaQ+I0sR0Fp3jAkn7wLrJ5JuzzRn/uMDTS64hTn9RzTC q3uMtgsoPLzUBmBCebeOMc+bZl1qMXQN+oZrPZCf2XdKlEyJSpoEa8ZNFak+tTwwFd8q hGdw== X-Gm-Message-State: AOJu0Yxw0B6bYQX9B5YSU3yianQzVj0Mxl8tPR1Sq7gC44AZH4Stt/+b z67R72FQwfUAt0OBrj6NGyOePRgi+JjHGzKfYFcLNmzSwn7qhFYnZQ0Xfpb5QllGROugX7ZBleA RFbEIH/cVwJjWXJFS6tuGOnfmd1E= X-Google-Smtp-Source: AGHT+IF1sNBH+mqzhQrx1kvgxUspFWjgcORcnwWCQPg2FXQCQ+CxOmwOHOnzP9c82W4GK9MqWI7C4LrlL+SHVh7n6NU= X-Received: by 2002:ac2:4d17:0:b0:516:d64a:28e1 with SMTP id r23-20020ac24d17000000b00516d64a28e1mr5311076lfi.55.1712573273010; Mon, 08 Apr 2024 03:47:53 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Richard Biener Date: Mon, 8 Apr 2024 12:47:42 +0200 Message-ID: Subject: Re: [PATCH] testsuite: Add profile_update_atomic check to gcov-20.c [PR114614] To: "Kewen.Lin" Cc: GCC Patches , j@lambda.is, Peter Bergner , Segher Boessenkool Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Apr 8, 2024 at 11:23=E2=80=AFAM Kewen.Lin wro= te: > > Hi, > > As PR114614 shows, the newly added test case gcov-20.c by > commit r14-9789-g08a52331803f66 failed on targets which do > not support atomic profile update, there would be a message > like: > > warning: target does not support atomic profile update, > single mode is selected > > Since the test case adopts -fprofile-update=3Datomic, it > requires effective target check profile_update_atomic, this > patch is to add the check accordingly. > > Tested well on x86_64-redhat-linux, powerpc64-linux-gnu P8/P9 > and powerpc64le-linux-gnu P9/P10. > > Is it ok for trunk? OK > BR, > Kewen > ----- > PR testsuite/114614 > > gcc/testsuite/ChangeLog: > > * gcc.misc-tests/gcov-20.c: Add effective target check > profile_update_atomic. > --- > gcc/testsuite/gcc.misc-tests/gcov-20.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/gcc/testsuite/gcc.misc-tests/gcov-20.c b/gcc/testsuite/gcc.m= isc-tests/gcov-20.c > index 215faffc980..ca8c12aad2b 100644 > --- a/gcc/testsuite/gcc.misc-tests/gcov-20.c > +++ b/gcc/testsuite/gcc.misc-tests/gcov-20.c > @@ -1,5 +1,6 @@ > /* { dg-options "-fcondition-coverage -ftest-coverage -fprofile-update= =3Datomic" } */ > /* { dg-do run { target native } } */ > +/* { dg-require-effective-target profile_update_atomic } */ > > /* Some side effect to stop branches from being pruned */ > int x =3D 0; > -- > 2.43.0