From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7287 invoked by alias); 10 Nov 2015 10:04:28 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 7268 invoked by uid 89); 10 Nov 2015 10:04:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-yk0-f173.google.com Received: from mail-yk0-f173.google.com (HELO mail-yk0-f173.google.com) (209.85.160.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 10 Nov 2015 10:04:26 +0000 Received: by ykfs79 with SMTP id s79so76120784ykf.1 for ; Tue, 10 Nov 2015 02:04:24 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.13.210.4 with SMTP id u4mr2162751ywd.68.1447149864891; Tue, 10 Nov 2015 02:04:24 -0800 (PST) Received: by 10.37.93.11 with HTTP; Tue, 10 Nov 2015 02:04:24 -0800 (PST) In-Reply-To: <564135C7.6030405@redhat.com> References: <87io5eq8nv.fsf@e105548-lin.cambridge.arm.com> <564135C7.6030405@redhat.com> Date: Tue, 10 Nov 2015 10:04:00 -0000 Message-ID: Subject: Re: Use combined_fn in tree-vrp.c From: Richard Biener To: Bernd Schmidt Cc: GCC Patches , richard.sandiford@arm.com Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg01165.txt.bz2 On Tue, Nov 10, 2015 at 1:09 AM, Bernd Schmidt wrote: > On 11/07/2015 01:46 PM, Richard Sandiford wrote: >> >> @@ -3814,8 +3817,8 @@ extract_range_basic (value_range *vr, gimple *stmt) >> break; >> /* Both __builtin_ffs* and __builtin_popcount return >> [0, prec]. */ >> - CASE_INT_FN (BUILT_IN_FFS): >> - CASE_INT_FN (BUILT_IN_POPCOUNT): >> + CASE_CFN_FFS: >> + CASE_CFN_POPCOUNT: >> arg = gimple_call_arg (stmt, 0); >> prec = TYPE_PRECISION (TREE_TYPE (arg)); >> mini = 0; > > > So let me see if I understood this. From what we discussed the purpose of > these new internal functions is that they can have vector types. If so, > isn't this code (here and elsewhere) which expects integers potentially > going to be confused? We indeed need to add additional checks to most users of CASE_CFN_* to cover the bigger freedom that exists with respect to types. Richard, please audit all the cases you change for that. Thanks, Richard. > > > Bernd