From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27038 invoked by alias); 26 Jun 2014 07:40:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 27027 invoked by uid 89); 26 Jun 2014 07:40:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f169.google.com Received: from mail-wi0-f169.google.com (HELO mail-wi0-f169.google.com) (209.85.212.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 26 Jun 2014 07:40:43 +0000 Received: by mail-wi0-f169.google.com with SMTP id hi2so545529wib.4 for ; Thu, 26 Jun 2014 00:40:40 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.194.246.234 with SMTP id xz10mr14837205wjc.77.1403768440662; Thu, 26 Jun 2014 00:40:40 -0700 (PDT) Received: by 10.195.11.202 with HTTP; Thu, 26 Jun 2014 00:40:40 -0700 (PDT) In-Reply-To: References: Date: Thu, 26 Jun 2014 07:40:00 -0000 Message-ID: Subject: Re: [PATCH] Add missing -fdump-* options From: Richard Biener To: Teresa Johnson Cc: Xinliang David Li , "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg02095.txt.bz2 On Wed, Jun 25, 2014 at 4:21 PM, Teresa Johnson wrote: > On Tue, May 13, 2014 at 8:19 AM, Xinliang David Li wrote: >> On Tue, May 13, 2014 at 1:39 AM, Richard Biener >> wrote: >>> On Fri, May 9, 2014 at 5:54 PM, Teresa Johnson wrote: >>>> I discovered that the support for the documented -fdump-* options >>>> "optimized", "missed", "note" and "optall" was missing. Added that and >>>> fixed a minor typo in the documentation. >>>> >>>> Bootstrapped and tested on x86-64-unknown-linux-gnu. Ok for trunk? >>> >>> I'm not sure they were intented for user-consumption. ISTR they >>> are just an implementation detail exposed by -fopt-info-X (which is >>> where they are documented). >>> >>> The typo fix is ok, also adding a comment before the dump flags >>> definition to the above fact. >>> >>> David, do I remember correctly? >> >> I remember we talked about content filtering dump flags. Things like >> >> -fdump-xxx-ir <-- dump IR only >> -fdump-xxx-transformation <-- optimization note >> -fdump-xxx-debug <-- other debug traces >> >> Other than that, now I think 'details' and 'all' seem redundant. >> 'verbose' flag/modifier can achieve the same effect depending on the >> context. >> >> -fdump-xxx-ir-verbose <-- dump IR, and turn on IR modifiers such as >> vops, lineno, etc >> -fdump-xxx-transforamtion-verbose <-- dump transformations + missed >> optimizations + notes >> -fdump-xxx-debug-verbose <-- turn on detailed trace. > > The above proposal seems fine to me as a longer-term direction, but > also seems somewhat orthogonal to the issue my patch is trying to > solve in the short term, namely inconsistent documentation and > behavior: > > 1) "optimized", "missed", "note" and "optall" are documented as being > sub-options for -fdump-tree-* in doc/invoke.texi, but not implemented. > 2) "optimized", "missed", "note" and "optall" are however enabled via > -fdump-tree-all > > Could we at least fix these issues in the short term, as it doesn't > affect the documented behavior (but rather adds the documented > behavior)? Sure. Richard. > Thanks, > Teresa > >> >> thanks, >> >> David >> >> >>> >>> Thanks, >>> Richard. >>> >>>> Thanks, >>>> Teresa >>>> >>>> 2014-05-09 Teresa Johnson >>>> >>>> * doc/invoke.texi: Fix typo. >>>> * dumpfile.c: Add support for documented -fdump-* options >>>> optimized/missed/note/optall. >>>> >>>> Index: doc/invoke.texi >>>> =================================================================== >>>> --- doc/invoke.texi (revision 210157) >>>> +++ doc/invoke.texi (working copy) >>>> @@ -6278,7 +6278,7 @@ passes). >>>> @item missed >>>> Enable showing missed optimization information (only available in certain >>>> passes). >>>> -@item notes >>>> +@item note >>>> Enable other detailed optimization information (only available in >>>> certain passes). >>>> @item =@var{filename} >>>> Index: dumpfile.c >>>> =================================================================== >>>> --- dumpfile.c (revision 210157) >>>> +++ dumpfile.c (working copy) >>>> @@ -107,6 +107,10 @@ static const struct dump_option_value_info dump_op >>>> {"nouid", TDF_NOUID}, >>>> {"enumerate_locals", TDF_ENUMERATE_LOCALS}, >>>> {"scev", TDF_SCEV}, >>>> + {"optimized", MSG_OPTIMIZED_LOCATIONS}, >>>> + {"missed", MSG_MISSED_OPTIMIZATION}, >>>> + {"note", MSG_NOTE}, >>>> + {"optall", MSG_ALL}, >>>> {"all", ~(TDF_RAW | TDF_SLIM | TDF_LINENO | TDF_TREE | TDF_RTL | TDF_IPA >>>> | TDF_STMTADDR | TDF_GRAPH | TDF_DIAGNOSTIC | TDF_VERBOSE >>>> | TDF_RHS_ONLY | TDF_NOUID | TDF_ENUMERATE_LOCALS | TDF_SCEV)}, >>>> >>>> >>>> -- >>>> Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413 > > > > -- > Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413