From: Richard Biener <richard.guenther@gmail.com>
To: Zopolis0 <creatorsmithmdt@gmail.com>
Cc: Andrew Pinski <pinskia@gmail.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 19/56] Revert "Move void_list_node init to common code". (8ff2a92a0450243e52d3299a13b30f208bafa7e0)
Date: Fri, 2 Dec 2022 08:43:51 +0100 [thread overview]
Message-ID: <CAFiYyc1=y7iy-RpBsq301R_72kAeY=En4sUrWTLHqxULTz0fQA@mail.gmail.com> (raw)
In-Reply-To: <CAEYL+X9mQNwWUr1k8g2LTxG3_NfgMFa-fz3NMcVNeMqARpSv1w@mail.gmail.com>
On Fri, Dec 2, 2022 at 1:23 AM Zopolis0 <creatorsmithmdt@gmail.com> wrote:
>
> > But that looks like the correct thing to do.
>
> It's not. The patch I reverted changes it so that no matter what,
> void_list_node = build_tree_list (NULL_TREE, void_type_node);.
>
> Before, each front-end set it in their own way, but they all set it
> via void_list_node = build_tree_list (NULL_TREE, void_type_node); or a
> synonym anyway. So while the patch made sense in a java-free context,
> given that java sets it a different way, I can't see a world in which
> this commit stays active and Java works, unless we find a way to set
> it in tree.cc for every language except Java.
The middle-end expects it to be this way, it's not correct for a frontend
to define it in other ways. That means you need to try to understand
_why_ the frontend isn't happy with the middle-ends definition.
How does Java build end_params_node?
Richard.
next prev parent reply other threads:[~2022-12-02 7:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 8:40 Zopolis0
2022-11-25 20:17 ` Richard Biener
2022-11-26 1:40 ` Zopolis0
2022-11-26 7:17 ` Richard Biener
2022-11-26 7:35 ` Zopolis0
2022-11-26 7:48 ` Andrew Pinski
2022-11-26 8:41 ` Zopolis0
2022-11-28 8:27 ` Richard Biener
2022-12-02 0:22 ` Zopolis0
2022-12-02 7:43 ` Richard Biener [this message]
2022-12-02 7:48 ` Richard Biener
2022-12-02 10:38 ` Zopolis0
2022-12-14 23:00 ` Zopolis0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiYyc1=y7iy-RpBsq301R_72kAeY=En4sUrWTLHqxULTz0fQA@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=creatorsmithmdt@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=pinskia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).