From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71782 invoked by alias); 26 Sep 2019 07:33:32 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 71772 invoked by uid 89); 26 Sep 2019 07:33:31 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1437 X-HELO: mail-lf1-f66.google.com Received: from mail-lf1-f66.google.com (HELO mail-lf1-f66.google.com) (209.85.167.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 26 Sep 2019 07:33:30 +0000 Received: by mail-lf1-f66.google.com with SMTP id w67so918753lff.4 for ; Thu, 26 Sep 2019 00:33:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6m7g6yCKoiaZsx4CvH1u3veuG4502UoitDam57bf5wM=; b=o+grb2act6dV7Yx/dPaSzeHXV7Ol897JpFXzZKG/1osqsgAJiHf1MZmtbuT1utGwS/ 7uxSNG0xbfT4tABMn5K65Fm1ndQJ2kZ9Kz/hLpMkmuppmyagmqrNqMUALw+6F82FF9ad Q4ug2KkxJ8LpfZh80WxrRv07j5JxtS060eT8mEYyqP3Wzf3iMVxQdYbFumaYj6u6TmIM kpTJF8vkUER6JbzTxJLip9RiqT8Rr5fR4vKq3umQ/mIpSSovU6Dp6Kd4DVV1LWavgCSV CWJFGukVBFqa9ZIM/4U7nlmE+Da9Gwv8psODeD0LaV8OkHtgmCPSprGYKjHl0pTcIPZo CocA== MIME-Version: 1.0 References: In-Reply-To: From: Richard Biener Date: Thu, 26 Sep 2019 07:33:00 -0000 Message-ID: Subject: Re: [PATCH] Fix continue condition in IPA-SRA's process_scan_results To: Martin Jambor Cc: Richard Sandiford , GCC Patches , Jan Hubicka , Jan Hubicka Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-09/txt/msg01504.txt.bz2 On Wed, Sep 25, 2019 at 4:18 PM Martin Jambor wrote: > > Hi, > > On Tue, Sep 24 2019, Martin Jambor wrote: > > > > > > It is the correct thing to do, sorry for the breakage. I have to run > > now but will prepare a patch tomorrow. > > > > and here it is. The patch fixes the thinko explained in my email > yesterday - basically the test for locally_unused was intended for > unused aggregates which have however not been marked as such yet and > going this way for unsplitable but unused register-type parameters may > cause problems in some cases, if they are for example big SVE vectors. > > Passed bootstrap and testing on x86_64-linux. OK for trunk? OK. Richard. > Thanks, > > Martin > > > 2019-09-25 Martin Jambor > > * ipa-sra.c (process_scan_results): Fix continue condition. > --- > gcc/ipa-sra.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/ipa-sra.c b/gcc/ipa-sra.c > index 0ccebbd4607..b35fff69472 100644 > --- a/gcc/ipa-sra.c > +++ b/gcc/ipa-sra.c > @@ -2239,7 +2239,7 @@ process_scan_results (cgraph_node *node, struct function *fun, > desc_index++, parm = DECL_CHAIN (parm)) > { > gensum_param_desc *desc = &(*param_descriptions)[desc_index]; > - if (!desc->locally_unused && !desc->split_candidate) > + if (!desc->split_candidate) > continue; > > if (flag_checking) > -- > 2.23.0 >