From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by sourceware.org (Postfix) with ESMTPS id A90883858C2B for ; Thu, 20 Jul 2023 07:32:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A90883858C2B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2b6f97c7115so6133121fa.2 for ; Thu, 20 Jul 2023 00:32:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689838353; x=1690443153; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=eRjrxbWrcTKlBBIr7NNZmzH9NZamL37mC4N0c9Kvhrw=; b=sf8TPWQGLprfuuueq4g3IYlFJ7Qiub6ELHPtYR4e0yzwmGE+QL0g2Zo8tUqgZC4n1Q DGVYp3FZjGB0Nv+XqGSCxlShYVlLHP5SS3nJ7yUtFgP0GQSNLyVgTRnsLx/p/mww8D81 0dAoGqDVBBsu9aVWSDWUegdI0TRI1Nz6oUS0Y3iK8kmoCGafixLAchoWE7Ma1FANL0Cv jlbBVjVzxNSJAS8CayLNHzt5T/bY5vR90wvJgpNfJKK8UMOpiE9p+r8DFP/Vc93d2RSq 8JCvr+zPolz3I3uqg29zfOUc1ol+36qoo1BIMeXeF47wIj6FGb3Hym7Sb9HqZ2l/ewSv 5ysQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689838353; x=1690443153; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eRjrxbWrcTKlBBIr7NNZmzH9NZamL37mC4N0c9Kvhrw=; b=c5wv4roYJlthT/ZFoO4Gjdcq6nOXASgwZIlvI0+YHf0pAX0LpzFHTvaSlIJB9QJaNf D1ZmYSIrcvbSs6cLbvM29TKs74yxv2AHzKLT1wwe7X6+TlGCfNvO8vSt7mejGblpftKt lNKanDebmFeRrKVPeWj22k0pm6Kd4qfdwhQXAnAyJXXDjGXMVjMV29sRnFSjc6uDBNh8 40gV3DQzAlqm2LkiPFuHTzuaQ106dbjg00O3Sm15b8bLI3eG+h0gk1ElA4/Ees286vty fOP9JSSs42FnjkCU7hNySxrmH/Wm4cu11gAZE8WLlnJsQ0EJFay6yu2jOB6KZyOfsvLR KkBg== X-Gm-Message-State: ABy/qLaARdz2ercKhu7j95mNDWUU50tZaFfltV2v8d5BImoF1RFIAPNc RAYV6Hyb7O5OMlX/+RI7XVvnYm8rcAN1G4jVGWY= X-Google-Smtp-Source: APBJJlFZMPN3VyHCznq11XyYiCeTuN00sHf3rviCi0xKMG4dIKxDcXFQaQeb9oq98P9QFh/FU8cP59MpdJU7LwicU3E= X-Received: by 2002:a2e:9e9a:0:b0:2b6:c4fd:753a with SMTP id f26-20020a2e9e9a000000b002b6c4fd753amr1111625ljk.34.1689838352985; Thu, 20 Jul 2023 00:32:32 -0700 (PDT) MIME-Version: 1.0 References: <003e01d9ba8d$e5cd4390$b167cab0$@nextmovesoftware.com> In-Reply-To: <003e01d9ba8d$e5cd4390$b167cab0$@nextmovesoftware.com> From: Richard Biener Date: Thu, 20 Jul 2023 09:31:58 +0200 Message-ID: Subject: Re: [PATCH] PR c/110699: Defend against error_mark_node in gimplify.cc. To: Roger Sayle Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Jul 20, 2023 at 12:11=E2=80=AFAM Roger Sayle wrote: > > > This patch resolves PR c/110699, an ICE-after-error regression, by adding > a check that the array type isn't error_mark_node in gimplify_compound_lv= al. > > This patch has been tested on x86_64-pc-linux-gnu with make bootstrap > and make -k check, both with and without --target_board=3Dunix{-m32} > with no new failures. Ok for mainline? Can you change it to if (error_operand_p (TREE_OPERAND (t, 0)) return GS_ERROR; and do that unconditionally for each 't' on the expr_stack? It seems we on= ly ever push handled_component_p to it. OK with that change. Richard. > > > 2023-07-19 Roger Sayle > > gcc/ChangeLog > PR c/110699 > * gimplify.cc (gimplify_compound_lval): For ARRAY_REF and > ARRAY_RANGE_REF return GS_ERROR if the array's type is > error_mark_node. > > gcc/testsuite/ChangeLog > PR c/110699 > * gcc.dg/pr110699.c: New test case. > > > Cheers, > Roger > -- >