From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by sourceware.org (Postfix) with ESMTPS id 592593858D37 for ; Wed, 21 Sep 2022 07:39:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 592593858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x52c.google.com with SMTP id w28so7347016edi.7 for ; Wed, 21 Sep 2022 00:39:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=X62SjjEg2nVEPylsdpIEIQzGZLL6grdX7oghe0HmO6I=; b=ExbTnnwx0dlarxkBrA/4ALp9Y43sbZlmPo3Qp2BrwR76GEXogXTDoKpvvcJDCOwmm2 HL34qnl4DuQDcr628GUlnKP41OzUS3YxtOkR62+ZHpI+N5D385ZHldXRZw3gU5dvabow zXed9rxkJZFlemiXm1CJf0cBGu+kV+mUlXtpkRBFe08K+Ga8DM8eRMxr5NJaPg/0wmiJ Gjb7lqo7eDStGAdid+qkryVTBXbWHkuAfzkE4mYoHrsTXsgvgaDUSfd5oniGptEHJAPJ oVhNqPiDMlHlSKCr4Ar54eNH6SUJy5oDDl//9cQq4mbkNOMDxsitN/tWM+1WoLYe5MUU Ze1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=X62SjjEg2nVEPylsdpIEIQzGZLL6grdX7oghe0HmO6I=; b=HIDYKOWYulfvJxTxGE4wJof8NhxH6BrI5tgLNUd2bAYNwj9aiOH0sd+Zveawmr5Qfs 7tIDXyU9Zzvc7LckpxP7nUqrU/j+h73++v0TcY2lrEUgfZM0Km0RHotiLa2B0RtvE5XI XOf4EymTM2CXFWyPeS0Gek7dRItHfOVUIoe3WqvgFXvzI9b9ZjqzGb8+RjQrmjZcRifc VJ3W61x2J4W/YYdFAXsT6a74dEIhuB0KoR06LS9u63vuPLg5XpvrBbjFIoyFioRwkpyn TdtLw2Kz7MafbipAP/X81ikNkv6kKTT+CITl5nggW4zQylWOLGks5tlGmEznukS0GSwo niuw== X-Gm-Message-State: ACrzQf0vnBXXJuE02SH6WCEnwXGmYD0LPekpDooTXMftcv5FpTTBlOUb bqIULXKnTxGtbvD0rc9GADORYQbb2lKYBw/YNlBH602b X-Google-Smtp-Source: AMsMyM45l5l9qSUeNmDzvHLTaA9ea1UzItT8p0zkUnqVpGIfpjpQ/SJNH+7pHjFalaJ2trGTa1DrfUpv8pcn2G6u6qk= X-Received: by 2002:aa7:d6c7:0:b0:452:2604:ae8b with SMTP id x7-20020aa7d6c7000000b004522604ae8bmr23386245edr.94.1663745949143; Wed, 21 Sep 2022 00:39:09 -0700 (PDT) MIME-Version: 1.0 References: <20220920182223.2019637-1-aldyh@redhat.com> In-Reply-To: <20220920182223.2019637-1-aldyh@redhat.com> From: Richard Biener Date: Wed, 21 Sep 2022 09:38:56 +0200 Message-ID: Subject: Re: [COMMITTED] frange::maybe_isnan() should return FALSE for undefined ranges. To: Aldy Hernandez Cc: GCC patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Sep 20, 2022 at 8:23 PM Aldy Hernandez via Gcc-patches wrote: > > Undefined ranges have undefined NAN bits. We can't depend on them, > as they may contain garbage. Ick ;) Can you add a comment at least? > This patch returns false from > maybe_isnan() for undefined ranges (the empty set). > > gcc/ChangeLog: > > * value-range.h (frange::maybe_isnan): Return false for > undefined ranges. > --- > gcc/value-range.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/gcc/value-range.h b/gcc/value-range.h > index 7d5584a9294..325ed08f290 100644 > --- a/gcc/value-range.h > +++ b/gcc/value-range.h > @@ -1210,6 +1210,8 @@ frange::known_isinf () const > inline bool > frange::maybe_isnan () const > { > + if (undefined_p ()) > + return false; > return m_pos_nan || m_neg_nan; > } > > -- > 2.37.1 >