From: Richard Biener <richard.guenther@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: "Alexander Monakov" <amonakov@ispras.ru>,
"Martin Liška" <mliska@suse.cz>,
"Uros Bizjak" <ubizjak@gmail.com>,
"GCC Patches" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Make target_clones resolver fn static.
Date: Mon, 20 Jan 2020 14:59:00 -0000 [thread overview]
Message-ID: <CAFiYyc1G696raL3RY3YVuZuz80PtDGt4yKxzHXbEtvNYm_bEkA@mail.gmail.com> (raw)
In-Reply-To: <CAMe9rOrvHuaD4XDwAZckSMMB_bW7H0eXd26BcHXqpHDoxnFQKQ@mail.gmail.com>
On Mon, Jan 20, 2020 at 3:46 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Mon, Jan 20, 2020 at 6:41 AM Alexander Monakov <amonakov@ispras.ru> wrote:
> >
> >
> >
> > On Mon, 20 Jan 2020, H.J. Lu wrote:
> >
> > > > Bare IFUNC's don't seem to have this restriction. Why do we want to
> > > > constrain target clones this way?
> > > >
> > >
> > > foo's resolver acts as foo. It should have the same visibility as foo.
> >
> > What do you mean by that? From the implementation standpoint, there's
> > two symbols of different type with the same value. There's no problem
> > allowing one of them have local binding and the other have global binding.
> >
> > Is there something special about target clones that doesn't come into
> > play with ifuncs?
> >
>
> I stand corrected. Resolver should be static and it shouldn't be weak.
Reading the patch again and looking up more context it seems that the resolver
is already static we just mangle it extra when the original function
is public (?)
If so the patch looks quite obvious to me if we use some character not valid
in indetifiers in C but valid in assembly for the resolver decl.
Richard.
>
> --
> H.J.
next prev parent reply other threads:[~2020-01-20 14:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 11:09 Martin Liška
2020-01-20 10:34 ` Richard Biener
2020-01-20 13:40 ` H.J. Lu
2020-01-20 13:48 ` Alexander Monakov
2020-01-20 13:49 ` H.J. Lu
2020-01-20 14:23 ` Alexander Monakov
2020-01-20 14:31 ` H.J. Lu
2020-01-20 14:54 ` Alexander Monakov
2020-01-20 14:55 ` H.J. Lu
2020-01-20 14:59 ` Richard Biener [this message]
2020-01-21 13:29 ` Martin Liška
2020-01-23 13:43 ` Richard Biener
2020-01-23 13:53 ` Martin Liška
2020-01-23 14:02 ` Alexander Monakov
2020-01-27 10:59 ` Martin Liška
2020-03-17 16:40 ` [stage1] [PATCH] Make target_clones resolver fn static if possible Martin Liška
2020-03-23 15:09 ` Martin Liška
2020-03-24 17:21 ` Jeff Law
2020-03-26 9:23 ` Jakub Jelinek
2020-03-26 9:46 ` Martin Liška
2020-03-26 9:48 ` Jakub Jelinek
2020-01-26 21:18 ` [PATCH] Make target_clones resolver fn static Jeff Law
2020-01-27 11:05 ` Martin Liška
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc1G696raL3RY3YVuZuz80PtDGt4yKxzHXbEtvNYm_bEkA@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=amonakov@ispras.ru \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=mliska@suse.cz \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).