From: Richard Biener <richard.guenther@gmail.com>
To: Patrick Palka <patrick@parcs.ath.cx>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fix PR tree-optimization/71314
Date: Tue, 31 May 2016 10:32:00 -0000 [thread overview]
Message-ID: <CAFiYyc1GO-tZPDziD3oSBcu0Mn7SteHd4s1PodyC+KZgVzSk9A@mail.gmail.com> (raw)
In-Reply-To: <20160530195052.24225-1-patrick@parcs.ath.cx>
On Mon, May 30, 2016 at 9:50 PM, Patrick Palka <patrick@parcs.ath.cx> wrote:
> The test case ssa-thread-14.c expects that non-short-circuit logical ops
> are used so it fails on targets that don't use such ops by default. To
> fix, I copied the dg directives from tree-ssa/reassoc-35.c which look
> reasonable. Does this look OK to commit?
Yes.
Richard.
> gcc/testsuite/ChangeLog:
>
> PR tree-optimization/71314
> * gcc.dg/tree-ssa/ssa-thread-14.c: Adjust target selector. Pass
> -mbranch-cost= 2.
> ---
> gcc/testsuite/gcc.dg/tree-ssa/ssa-thread-14.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gcc/testsuite/gcc.dg/tree-ssa/ssa-thread-14.c b/gcc/testsuite/gcc.dg/tree-ssa/ssa-thread-14.c
> index e2ac2f7..c754b5b 100644
> --- a/gcc/testsuite/gcc.dg/tree-ssa/ssa-thread-14.c
> +++ b/gcc/testsuite/gcc.dg/tree-ssa/ssa-thread-14.c
> @@ -1,5 +1,6 @@
> -/* { dg-do compile } */
> +/* { dg-do compile { target { ! { m68k*-*-* mmix*-*-* mep*-*-* bfin*-*-* v850*-*-* moxie*-*-* cris*-*-* m32c*-*-* fr30*-*-* mcore*-*-* powerpc*-*-* xtensa*-*-* hppa*-*-* nios2*-*-* } } } } */
> /* { dg-additional-options "-O2 -fdump-tree-vrp-details" } */
> +/* { dg-additional-options "-mbranch-cost=2" { target mips*-*-* avr-*-* s390*-*-* i?86-*-* x86_64-*-* } } */
> /* { dg-final { scan-tree-dump-times "Threaded jump" 8 "vrp1" } } */
>
> void foo (void);
> --
> 2.9.0.rc0.29.gabd6606
>
prev parent reply other threads:[~2016-05-31 9:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 8:22 Patrick Palka
2016-05-31 10:32 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc1GO-tZPDziD3oSBcu0Mn7SteHd4s1PodyC+KZgVzSk9A@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=patrick@parcs.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).