From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26962 invoked by alias); 31 May 2016 09:21:17 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 26949 invoked by uid 89); 31 May 2016 09:21:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1446 X-HELO: mail-wm0-f67.google.com Received: from mail-wm0-f67.google.com (HELO mail-wm0-f67.google.com) (74.125.82.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 31 May 2016 09:21:08 +0000 Received: by mail-wm0-f67.google.com with SMTP id q62so30654136wmg.3 for ; Tue, 31 May 2016 02:21:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=D5n/ulLKlTHhU0VlU58b0IHoXOFncQYnzFgAgVIPGgg=; b=JEF35JkgumMyJIGI4Ta0NJYiNVL1EEx0F3NPkAdBqhRvL1PaqqTwaJKz7+CoqfgvzY P6FbVkoIUxqAs4R+K3h5P7Vw+YdUlXAKDTdPufkL9PWzZ1uvbGOOvNVJZJb+EB4sFH8T SSEAvJn48yRr/onJs6j5OTIsPmLTDqTjM2G90hn8NcZMFKR1nDZ404V52EZVsRQoBXIl otKOn/D0hBm2Yk6g5L/qngTKZkGcFQoHiVRV3Sszq6BcrpJo5+ApOsOs2FzQ+gxliKfa m6nnjlwIYuPMrkDj4IWEo8ulxtrUirjV8snUSrNgaUlGok73xLnGLMVl7CKEqQ7A2ocX ogjw== X-Gm-Message-State: ALyK8tIJ0Xuf21VSsWodOHIgaQWP/1sqdclgn0rcQIS7lOLjyu2q1JT0F5skuKJJkCTOtD6GyU5OS/j3uWMpug== MIME-Version: 1.0 X-Received: by 10.28.154.130 with SMTP id c124mr15512883wme.9.1464686465828; Tue, 31 May 2016 02:21:05 -0700 (PDT) Received: by 10.194.87.34 with HTTP; Tue, 31 May 2016 02:21:05 -0700 (PDT) In-Reply-To: <20160530195052.24225-1-patrick@parcs.ath.cx> References: <20160530195052.24225-1-patrick@parcs.ath.cx> Date: Tue, 31 May 2016 10:32:00 -0000 Message-ID: Subject: Re: [PATCH] Fix PR tree-optimization/71314 From: Richard Biener To: Patrick Palka Cc: GCC Patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2016-05/txt/msg02385.txt.bz2 On Mon, May 30, 2016 at 9:50 PM, Patrick Palka wrote: > The test case ssa-thread-14.c expects that non-short-circuit logical ops > are used so it fails on targets that don't use such ops by default. To > fix, I copied the dg directives from tree-ssa/reassoc-35.c which look > reasonable. Does this look OK to commit? Yes. Richard. > gcc/testsuite/ChangeLog: > > PR tree-optimization/71314 > * gcc.dg/tree-ssa/ssa-thread-14.c: Adjust target selector. Pass > -mbranch-cost= 2. > --- > gcc/testsuite/gcc.dg/tree-ssa/ssa-thread-14.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/gcc/testsuite/gcc.dg/tree-ssa/ssa-thread-14.c b/gcc/testsuite/gcc.dg/tree-ssa/ssa-thread-14.c > index e2ac2f7..c754b5b 100644 > --- a/gcc/testsuite/gcc.dg/tree-ssa/ssa-thread-14.c > +++ b/gcc/testsuite/gcc.dg/tree-ssa/ssa-thread-14.c > @@ -1,5 +1,6 @@ > -/* { dg-do compile } */ > +/* { dg-do compile { target { ! { m68k*-*-* mmix*-*-* mep*-*-* bfin*-*-* v850*-*-* moxie*-*-* cris*-*-* m32c*-*-* fr30*-*-* mcore*-*-* powerpc*-*-* xtensa*-*-* hppa*-*-* nios2*-*-* } } } } */ > /* { dg-additional-options "-O2 -fdump-tree-vrp-details" } */ > +/* { dg-additional-options "-mbranch-cost=2" { target mips*-*-* avr-*-* s390*-*-* i?86-*-* x86_64-*-* } } */ > /* { dg-final { scan-tree-dump-times "Threaded jump" 8 "vrp1" } } */ > > void foo (void); > -- > 2.9.0.rc0.29.gabd6606 >