From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by sourceware.org (Postfix) with ESMTPS id 0BF043858D32 for ; Wed, 5 Jul 2023 06:21:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0BF043858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-4fb9fd28025so8933191e87.2 for ; Tue, 04 Jul 2023 23:21:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688538101; x=1691130101; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=uwHZjg3ZLRX3dyrjMBB+DDbf8z3WUDl+xPKLZHHEICI=; b=hmn3IhOpcftfzRqisyXg1Z6JH1EHSg31a9vkZVOzaJiID3ohR1VJII1iF5k2IKPz2M uwEiUd11d0U1d6N9hE8tAqP/xw3IHQRgmzzTskp9pyCTIQfV8CJ+1iAjdqM/4B5LKRti iQUJq46v2IvfxwEI814tTX2r4rvYw/5KsZdMzRFDlvOW4IFtaiquP4rjkl56K6DtrtvC RoLu/OHdhHW4gSTQXUKgPQ8XFV4qjPJyUCajZch7e0P/hEvtR+gSTLYvLQxfmCtE0MBZ JonFemgxyh4N9vCt5/V11q5WyeYqBTA2SZs/kw5aboOt3YQFp6lxWezRyn8XfXNw7h3e +c1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688538101; x=1691130101; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uwHZjg3ZLRX3dyrjMBB+DDbf8z3WUDl+xPKLZHHEICI=; b=JiKhnCfduILCh+5MQRppN+vf85MChH0iCzhJt44etK+FJ6jtzruxWRPwgjQbnUaws2 ZijdM26ZNNBfRmKYoZ9O2Ic5VotiikKFmlPco66/kINDENo4eajxPPFOI/Y7k7Lol8fl MHfvN+JMPPUKaBmY4lkAWza5TSFhC0ZBpK7ioHBbPH0XB+AFUM1vqPH8M4m+7PPP4nFJ 1v1oIKPKfhQd6buyMN92/X3Dxexovwj/78dwt1Zg1BT5nzk2hcKLF+8z/Q9GpzTYCveG dqknsLmro1/MMDur0p9FM4iGWH/Btw6m/LcAUI4Sd2gbhLMc6P8OY+SNOSZQfps04S16 wyxw== X-Gm-Message-State: ABy/qLbjyhe0k5a9Ce4J1HTi0AlzExk3VIU+6poC33baevxVnjlon0+n U8fX1qU2y1WHvTWaDQw/+ggysdfWR0D7REwdSTw= X-Google-Smtp-Source: APBJJlHLqI1uu5zFSAEJ1Tu4hjZY1f0G8OcMbaey2rZ5/PccPhn+P4bq1sl1BNygMJSVqFu6bqMlbSiY1x6zNjiV+rU= X-Received: by 2002:a2e:b6cd:0:b0:2b6:daa3:f0af with SMTP id m13-20020a2eb6cd000000b002b6daa3f0afmr8267736ljo.25.1688538101142; Tue, 04 Jul 2023 23:21:41 -0700 (PDT) MIME-Version: 1.0 References: <20130122143307.GA3824@google.com> <50FFAB3C.6060202@arm.com> <72a04a5e-7da6-4809-a9a8-b5ecffd01351@email.android.com> <20130123143258.GH7269@tucnak.redhat.com> <87edlnvfb8.fsf@euler.schwinge.homeip.net> In-Reply-To: <87edlnvfb8.fsf@euler.schwinge.homeip.net> From: Richard Biener Date: Wed, 5 Jul 2023 08:18:18 +0200 Message-ID: Subject: Re: GGC: Remove unused 'bool is_string' arguments to 'ggc_pch_{count,alloc,write}_object' (was: RFA - Remove GC zone allocator) To: Thomas Schwinge Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Jul 4, 2023 at 5:59=E2=80=AFPM Thomas Schwinge wrote: > > Hi! > > On 2013-01-24T10:14:58-0500, Diego Novillo wrote: > > [...] the patch [...] committed [...] > > This did clean up some things: > > > --- a/gcc/ggc-internal.h > > +++ b/gcc/ggc-internal.h > > @@ -55,8 +55,7 @@ extern struct ggc_pch_data *init_ggc_pch (void); > > of an object. Update the ggc_pch_data structure with as much of > > that information as is necessary. The bool argument should be true > > if the object is a string. */ > > -extern void ggc_pch_count_object (struct ggc_pch_data *, void *, size_= t, bool, > > - enum gt_types_enum); > > +extern void ggc_pch_count_object (struct ggc_pch_data *, void *, size_= t, bool); > > > > /* Return the total size of the data to be written to hold all > > the objects previously passed to ggc_pch_count_object. */ > > @@ -69,8 +68,7 @@ extern void ggc_pch_this_base (struct ggc_pch_data *,= void *); > > /* Assuming that the objects really do end up at the address > > passed to ggc_pch_this_base, return the address of this object. > > The bool argument should be true if the object is a string. */ > > -extern char *ggc_pch_alloc_object (struct ggc_pch_data *, void *, size= _t, bool, > > - enum gt_types_enum); > > +extern char *ggc_pch_alloc_object (struct ggc_pch_data *, void *, size= _t, bool); > > > --- a/gcc/ggc-page.c > > +++ b/gcc/ggc-page.c > > > @@ -2230,8 +2221,7 @@ init_ggc_pch (void) > > > > void > > ggc_pch_count_object (struct ggc_pch_data *d, void *x ATTRIBUTE_UNUSED= , > > - size_t size, bool is_string ATTRIBUTE_UNUSED, > > - enum gt_types_enum type ATTRIBUTE_UNUSED) > > + size_t size, bool is_string ATTRIBUTE_UNUSED) > > { > > unsigned order; > > > > @@ -2274,8 +2264,7 @@ ggc_pch_this_base (struct ggc_pch_data *d, void *= base) > > > > char * > > ggc_pch_alloc_object (struct ggc_pch_data *d, void *x ATTRIBUTE_UNUSED= , > > - size_t size, bool is_string ATTRIBUTE_UNUSED, > > - enum gt_types_enum type ATTRIBUTE_UNUSED) > > + size_t size, bool is_string ATTRIBUTE_UNUSED) > > { > > unsigned order; > > char *result; > > ..., but left in other 'ATTRIBUTE_UNUSED's. > > To enable another thing I'm working on, OK to push the attached clean-up > "GGC: Remove unused 'bool is_string' arguments to 'ggc_pch_{count,alloc,w= rite}_object'"? OK. Richard. > > Gr=C3=BC=C3=9Fe > Thomas > > > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 2= 01, 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch= =C3=A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellsc= haft: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955