From: Richard Biener <richard.guenther@gmail.com>
To: "Martin Liška" <mliska@suse.cz>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, Jan Hubicka <hubicka@ucw.cz>
Subject: Re: [PATCH] IPA: reduce what we dump in normal mode
Date: Tue, 2 Aug 2022 11:52:56 +0200 [thread overview]
Message-ID: <CAFiYyc1H-j-+Ey+bpLAFSJ=LkMffPCbCEX_zJqYuxz8u8dgv-A@mail.gmail.com> (raw)
In-Reply-To: <6a2508ac-9673-c759-c0a1-bd78a67105f6@suse.cz>
On Tue, Aug 2, 2022 at 10:46 AM Martin Liška <mliska@suse.cz> wrote:
OK
> gcc/ChangeLog:
>
> * profile.cc (compute_branch_probabilities): Dump details only
> if TDF_DETAILS.
> * symtab.cc (symtab_node::dump_base): Do not dump pointer unless
> TDF_ADDRESS is used, it makes comparison harder.
> ---
> gcc/profile.cc | 2 +-
> gcc/symtab.cc | 3 ++-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/gcc/profile.cc b/gcc/profile.cc
> index 08af512cbca..92de821b8bb 100644
> --- a/gcc/profile.cc
> +++ b/gcc/profile.cc
> @@ -766,7 +766,7 @@ compute_branch_probabilities (unsigned cfg_checksum, unsigned lineno_checksum)
> sum2 += freq2;
> }
> }
> - if (dump_file)
> + if (dump_file && (dump_flags & TDF_DETAILS))
> {
> double nsum1 = 0, nsum2 = 0;
> stats.qsort (cmp_stats);
> diff --git a/gcc/symtab.cc b/gcc/symtab.cc
> index 8670337416e..f2d96c0268b 100644
> --- a/gcc/symtab.cc
> +++ b/gcc/symtab.cc
> @@ -894,7 +894,8 @@ symtab_node::dump_base (FILE *f)
> };
>
> fprintf (f, "%s (%s)", dump_asm_name (), name ());
> - dump_addr (f, " @", (void *)this);
> + if (dump_flags & TDF_ADDRESS)
> + dump_addr (f, " @", (void *)this);
> fprintf (f, "\n Type: %s", symtab_type_names[type]);
>
> if (definition)
> --
> 2.37.1
>
next prev parent reply other threads:[~2022-08-02 9:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 8:46 Martin Liška
2022-08-02 9:52 ` Richard Biener [this message]
2022-08-02 16:27 ` Jan Hubicka
2022-08-03 8:56 ` Martin Liška
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiYyc1H-j-+Ey+bpLAFSJ=LkMffPCbCEX_zJqYuxz8u8dgv-A@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=mliska@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).