From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by sourceware.org (Postfix) with ESMTPS id D802E3858024 for ; Mon, 4 Dec 2023 14:22:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D802E3858024 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D802E3858024 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::12f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701699732; cv=none; b=k5JX0IXhPEJIIvA9TGwhYmo+e7qAzGqdjwR7P6X46CLMHIBgkozdAy6CgurYaK0F4PxM19A6mUJeMIU6bcCyeBEZ+baNtR0npEtAc2v/iZ9Wl9bQARRitLjcIkWPFF2i68CWOjWpYnJuQ0/nFn2q/c3C0FtvGtL8mJ8fK9UraLY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701699732; c=relaxed/simple; bh=LNpcuVkLAV9nSCYK7Tq8fZgPoHSfsJQbniVu5dWBJXU=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=mGSMp6/DglqBrdf31UjnwbqKYksRfRD3YiD+RIAgjNgHXvEsnaxOKAzkiqVQ0BGew7CJVIbzlXNwAPlbst21wsOvXHu/pbzx4X6v/+wJPusHbE2K7pZIzRgHxCQymIGJd2MVkpdjJF3xmBlc+wYlK+zGm51FwHyQPOJ7Bmd3UvA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-50bfd7be487so654135e87.0 for ; Mon, 04 Dec 2023 06:22:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701699729; x=1702304529; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=BslzxkqUsK9VwGxFJSzlWpOl7EqQhsl4BEBdM1+6ycU=; b=LurGznu1Xr6uGS1us8FGgD96vHhmdU2vG34yXSo2o4nBdmlzfSFNrnHspDIsML4nu+ tB1DRARo/ZNu8zyh+5Rc+tqqX3YGYOeeSCPXMZdWTzMtUiMC56FNAuGIvEr8tri79WBi t3n45FBB3jS8TR0B6eqVA/fqgufIPHsZRvYBZosBeB442opRG+482P3BZY+zpxQWchpn ENY6Rhz4NlTgoj0QMybGsl/8Q6LY0/ksWQdJ7sS73DoMehMzqQC+RoPQPP1Rpa0T8UGT hDHx32LX+7MFY7FFdvf6hYk9vwD88nvMDS5TMCz4fmf+1EWttFxCk0zGtoimh4xedeNZ hjGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701699729; x=1702304529; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BslzxkqUsK9VwGxFJSzlWpOl7EqQhsl4BEBdM1+6ycU=; b=LMfwNgG29nqWCl2xX2469qWVjgH2NbvV5YYHXPPbswfqB538QQEzypEJpq0xQjBzUJ r4riTRsggQaqmmTi/MVWsUnKbtt+rQfHw/zCkSZgEma8hdiS5ZHTUa75i0nex+vWySYQ +Q03kRGtfJI78wRh2mS3Ncf3C6nwPxqTyzDqVZP7NjtFZf0umiVsgSbMsMTrFcas35ee oFAWRuBSn2x7l8RLpSu2XM7IN090h8PzvQByYc2BakUGjH4GTsipgoXlp2vww81FC6ht 1y74++Ityli+QOoVDZULCljw/gnEaqkdTkzJileGcefopkpje4uhoo6R2rEyP3EmPS4x HojA== X-Gm-Message-State: AOJu0YzFWKSQcowi3moNdAjoJIj7+rgOr+Mg7UYUxdJH1Z5vzL4qSJpH 2p7i8RoV7qHLHxfAnOSZeU92/38XZlJpwV4ZSD0= X-Google-Smtp-Source: AGHT+IEQSpDxnqC6moOdQFRGmNORFMsbvZU5CuT4JnntfZiukvCGdX63Au3W0teivACM5I70HbQBtgQcLjL7EapLpEo= X-Received: by 2002:a05:6512:3d87:b0:50b:f1b2:3881 with SMTP id k7-20020a0565123d8700b0050bf1b23881mr1076690lfv.8.1701699729197; Mon, 04 Dec 2023 06:22:09 -0800 (PST) MIME-Version: 1.0 References: <20231202063725.3405094-1-quic_apinski@quicinc.com> <20231202063725.3405094-2-quic_apinski@quicinc.com> In-Reply-To: <20231202063725.3405094-2-quic_apinski@quicinc.com> From: Richard Biener Date: Mon, 4 Dec 2023 15:21:57 +0100 Message-ID: Subject: Re: [PATCH 1/3] MATCH: Fix zero_one_valued_p's convert pattern To: Andrew Pinski Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, Dec 2, 2023 at 7:38=E2=80=AFAM Andrew Pinski wrote: > > While working on PR 111972, I was getting a regression > due to zero_one_valued_p matching a signed 1 bit integer > when it came to convert. This patch fixes that by checking > the outer type too. > > Bootstrapped and tested on x86_64-linux-gnu with no regressions. OK > gcc/ChangeLog: > > * match.pd (zero_one_valued_p): For convert > make sure type is not a signed 1-bit integer. > > Signed-off-by: Andrew Pinski > --- > gcc/match.pd | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/gcc/match.pd b/gcc/match.pd > index 26383e55767..4d554ba4721 100644 > --- a/gcc/match.pd > +++ b/gcc/match.pd > @@ -2247,6 +2247,9 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) > (if (INTEGRAL_TYPE_P (TREE_TYPE (@1)) > && (TYPE_UNSIGNED (TREE_TYPE (@1)) > || TYPE_PRECISION (TREE_TYPE (@1)) > 1) > + && INTEGRAL_TYPE_P (type) > + && (TYPE_UNSIGNED (type) > + || TYPE_PRECISION (type) > 1) > && wi::leu_p (tree_nonzero_bits (@1), 1)))) > > /* Transform { 0 or 1 } * { 0 or 1 } into { 0 or 1 } & { 0 or 1 }. */ > -- > 2.39.3 >