From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by sourceware.org (Postfix) with ESMTPS id ADACE3839DE0 for ; Thu, 6 Oct 2022 12:21:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org ADACE3839DE0 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x52b.google.com with SMTP id a13so2595560edj.0 for ; Thu, 06 Oct 2022 05:21:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=cz1U5XhXOI4qV4p7udzUl0XnoznawGQB6MbtIJY1a8A=; b=eTmHKJciL15MMkYczOj3tbA7/Bq32/qEctB8YBE2wgRbUPli5A/spMFKjpFNhE2sy9 3K+VEy5Y0YyDa8phPRBbDmkRRtZkSfv47tJ/XSI87fOpBQ4twgI8jTFejgPTfBdK8Fti w7kjT2t42d4Z9JjPZqW1GdZS0WqnnF6+NVhAOdLSpaFZLHtmNkP4m1NXkLacPO8x88nc GGYJyFgY3jZg26xWR21kazyIR0DUf0kq6rC1DJR+zFyOpBK0I2rV78V9g0+3nZYQC/b2 CTsntsE2/AOy7w5AcqNw+FwQ7G+EIJaBiv+s42uTkg6OtEtWaw5YCZkVPOUs+QrH1DA/ 4LDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=cz1U5XhXOI4qV4p7udzUl0XnoznawGQB6MbtIJY1a8A=; b=MHUwwv2GLkfJi0TWvqLE7rqwEGCpY4lQisu+VD8MRSXJ0gURSoWy1U6v8iszal1qcX lwplcJN2RWXmIGAuLvK7WQ6HaWQTd9LZcfhBi7ZHgk7Vn/ZYbFjcLMTErTqQd79D3ZOJ HTaeYIhUCK4ZaTAb5VyQiVVqs/FRAVhchRduYjK1snCmRkV7/Ym0uFmuzsDcsotOxFsW ChF5vUvko/r2DzH8VN28mFPvzKqBkuS5WiNdMtZu5ELHVQ1UOqJ+5zpiwBNmhGRyx4If E1EC0VG25QGZqxv5Uim2VIuYZlwcXWN+95Bc6wsqw/eW/xw2YjesA0mdxKl+45kxky2i YWFQ== X-Gm-Message-State: ACrzQf2IsEN1QWxg+aMeql+Z5NZHvtDlkX2XaJTx9KMOFMfJapU/RypJ RgL3VChCed5Q7lRB9uoFiAFtRcjwcI0jGSVcF5A= X-Google-Smtp-Source: AMsMyM5+rY0iCPX/ssvSlRVjDr758k+QleduYLdVccOpco3XrawKrmOMkj5bh/jX46zGXVRwFsjYPRU8/GUsWyPCQ6M= X-Received: by 2002:a05:6402:1205:b0:458:c1b2:e428 with SMTP id c5-20020a056402120500b00458c1b2e428mr4315968edw.94.1665058889448; Thu, 06 Oct 2022 05:21:29 -0700 (PDT) MIME-Version: 1.0 References: <4094054.1IzOArtZ34@fomalhaut> <3695765.kQq0lBPeGt@fomalhaut> In-Reply-To: <3695765.kQq0lBPeGt@fomalhaut> From: Richard Biener Date: Thu, 6 Oct 2022 14:21:16 +0200 Message-ID: Subject: Re: [PATCH] Fix wrong code generated by unroll-and-jam pass To: Eric Botcazou Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Oct 6, 2022 at 1:09 PM Eric Botcazou wrote: > > > I'm wondering if testing DR_IS_WRITE (dra) is enough here and whether > > the logic also applies to RAW and WAR. So should it be either > > (DR_IS_WRITE (dra) || DR_IS_WRITE (drb)) or DR_IS_WRITE (dra) && > > DR_IS_WRITE (drb) instead? > > It's a self-dependence, i.e. dra == drb in the block. Or do you mean for > other dependence pairs in general? For them, I think that the code does the > proper filtering in adjust_unroll_factor, but I may be wrong of course. Ah, I see. The original patch is OK. thanks, Richard. > -- > Eric Botcazou > >