From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13640 invoked by alias); 13 Jul 2015 08:19:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 13630 invoked by uid 89); 13 Jul 2015 08:19:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oi0-f53.google.com Received: from mail-oi0-f53.google.com (HELO mail-oi0-f53.google.com) (209.85.218.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 13 Jul 2015 08:19:09 +0000 Received: by oibn4 with SMTP id n4so18374814oib.3 for ; Mon, 13 Jul 2015 01:19:07 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.60.176.37 with SMTP id cf5mr29323291oec.19.1436775547317; Mon, 13 Jul 2015 01:19:07 -0700 (PDT) Received: by 10.76.115.167 with HTTP; Mon, 13 Jul 2015 01:19:07 -0700 (PDT) In-Reply-To: References: <559BEB2D.7040800@redhat.com> Date: Mon, 13 Jul 2015 08:19:00 -0000 Message-ID: Subject: Re: [PATCH, ARM] stop changing signedness in PROMOTE_MODE From: Richard Biener To: Jim Wilson , Michael Matz Cc: Jeff Law , "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg01001.txt.bz2 On Fri, Jul 10, 2015 at 5:46 PM, Jim Wilson wrote: > On Tue, Jul 7, 2015 at 2:35 PM, Richard Biener > wrote: >> On July 7, 2015 6:29:21 PM GMT+02:00, Jim Wilson wrote: >>>signed sub-word locals. Thus to detect the need for a conversion, you >>>have to have the decls, and we don't have them here. There is also >> >> It probably is. The decks for the parameter based SSA names are available, for the PHI destination there might be no decl. > > I tried looking again, and found the decls. I'm able to get correct > code for my testcase with the attached patch to force the conversion. > It is rather inelegant, but I think I can cache the values I need to > make this simpler and cleaner. I still don't have decls from > insert_part_to_rtx_on_edge and insert_rtx_to_part_on_edge, but it > looks like those are for breaking cycles, and hence might not need > conversions. Yes, that looks like a defect. CCing Micha who wrote this code Richard. > Jim