From: Richard Biener <richard.guenther@gmail.com>
To: Jason Merrill <jason@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: RFA (tree.c): PATCH to make warn_deprecated_use return bool
Date: Wed, 16 May 2018 09:42:00 -0000 [thread overview]
Message-ID: <CAFiYyc1MTTDvUqi0r3Q08CL7izxFLYKRB3eijzspYc=AqYZGOQ@mail.gmail.com> (raw)
In-Reply-To: <CADzB+2=zOwhfW-4httHK2HWD4AAPWps0wb1SRFWRj7r30K1fnw@mail.gmail.com>
On Wed, May 16, 2018 at 3:01 AM Jason Merrill <jason@redhat.com> wrote:
> The function "warning" returns bool to indicated whether or not any
> diagnostic was actually emitted; warn_deprecated_use should as well.
> It's also unnecessary to duplicate the warning code between the cases
> of null or non-null "decl", since the actual warnings were the same.
> The only thing that's different is whether we indicate the source
> location of "decl".
> Tested x86_64-pc-linux-gnu. OK for trunk?
OK.
Richard.
prev parent reply other threads:[~2018-05-16 9:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 2:34 Jason Merrill
2018-05-16 9:42 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiYyc1MTTDvUqi0r3Q08CL7izxFLYKRB3eijzspYc=AqYZGOQ@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).