From: Richard Biener <richard.guenther@gmail.com>
To: Alexandre Oliva <oliva@adacore.com>
Cc: gcc-patches@gcc.gnu.org,
Rainer Orth <ro@cebitec.uni-bielefeld.de>,
Mike Stump <mikestump@comcast.net>
Subject: Re: [PATCH] [testsuite] tsvc: skip include malloc.h when unavailable
Date: Wed, 24 May 2023 11:02:14 +0200 [thread overview]
Message-ID: <CAFiYyc1NjZ6YReS5ATbWYi6HWjAPq-FZhhVyt7N6ydgwyhc2SQ@mail.gmail.com> (raw)
In-Reply-To: <or8rdeqpgh.fsf@lxoliva.fsfla.org>
On Wed, May 24, 2023 at 7:17 AM Alexandre Oliva via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
>
> tsvc tests all fail on systems that don't offer a malloc.h, other than
> those that explicitly rule that out. Use the preprocessor to test for
> malloc.h's availability.
>
> tsvc.h also expects a definition for struct timeval, but it doesn't
> include sys/time.h. Add a conditional include thereof.
>
> Bootstrapped on x86_64-linux-gnu. Also tested on ppc- and x86-vx7r2
> with gcc-12.
OK.
>
> for gcc/testsuite/ChangeLog
>
> * gcc.dg/vect/tsvc/tsvc.h: Test for and conditionally include
> malloc.h and sys/time.h.
>
> ---
> gcc/testsuite/gcc.dg/vect/tsvc/tsvc.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/gcc/testsuite/gcc.dg/vect/tsvc/tsvc.h b/gcc/testsuite/gcc.dg/vect/tsvc/tsvc.h
> index 75494c24cfa62..cd39c041903dd 100644
> --- a/gcc/testsuite/gcc.dg/vect/tsvc/tsvc.h
> +++ b/gcc/testsuite/gcc.dg/vect/tsvc/tsvc.h
> @@ -11,9 +11,12 @@
>
> #include <stdio.h>
> #include <stdlib.h>
> -#if !defined(__APPLE__) && !defined(__DragonFly__)
> +#if __has_include(<malloc.h>)
> #include <malloc.h>
> #endif
> +#if __has_include(<sys/time.h>)
> +#include <sys/time.h>
> +#endif
> #include <string.h>
> #include <math.h>
>
>
> --
> Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
> Free Software Activist GNU Toolchain Engineer
> Disinformation flourishes because many people care deeply about injustice
> but very few check the facts. Ask me about <https://stallmansupport.org>
next prev parent reply other threads:[~2023-05-24 9:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 5:16 Alexandre Oliva
2023-05-24 9:02 ` Richard Biener [this message]
2024-02-09 10:33 ` Torbjorn SVENSSON
2024-02-09 10:34 ` Richard Biener
2024-02-09 10:52 ` Torbjorn SVENSSON
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc1NjZ6YReS5ATbWYi6HWjAPq-FZhhVyt7N6ydgwyhc2SQ@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mikestump@comcast.net \
--cc=oliva@adacore.com \
--cc=ro@cebitec.uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).