From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73946 invoked by alias); 20 Sep 2016 11:31:48 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 73930 invoked by uid 89); 20 Sep 2016 11:31:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=H*Ad:D*edu.cn, Hx-languages-length:1566, H*Ad:D*cn, HCc:D*cn X-HELO: mail-lf0-f50.google.com Received: from mail-lf0-f50.google.com (HELO mail-lf0-f50.google.com) (209.85.215.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Sep 2016 11:31:37 +0000 Received: by mail-lf0-f50.google.com with SMTP id l131so10790651lfl.2 for ; Tue, 20 Sep 2016 04:31:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=K9eI3A1PqOn+K8IPiRkBOzCgFDJLaVZbMLbC+vmtrE4=; b=IKng6EwHeB9bu8UAbZZHOqpbBaXCmld2DJDijTgHyyAHp/VQHLjBzmGt5IGf3NCgQU hoMoh6MEHga9SUPUqCibFIQcsz5FrTxySaILStVQTTYG4BRq3FIINBAYTWqdzGTMO0MX 1j2a3jgrmntXRT6DZ9s/tTDXiW2fIU6YS5oKZNU5k4cit7AifRxG05Tsp+knKCZR23k1 5vBdgjqkcWux4QyCaxx87lJIBDAzfZrk5hf+ULn6m6bp4DHBZbyTms39LSvV3hPcabUI kxJ2JcwKBRlrl4OOyUNqoCl7XybHBoe2EJX/BwppA/98eYAKZbjhvrc1N3j9FQGHD3Zj srLg== X-Gm-Message-State: AE9vXwNLm87scn2wlJtaRz+S2pHTdPkKXNqdyVg1FESrGgwMjNUwRJJHc3YefGUyIg5CX2DM/hgLxg7RWJYYig== X-Received: by 10.195.2.40 with SMTP id bl8mr27490652wjd.191.1474371094971; Tue, 20 Sep 2016 04:31:34 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.137.129 with HTTP; Tue, 20 Sep 2016 04:31:34 -0700 (PDT) In-Reply-To: <20160916120037.GB3781@kam.mff.cuni.cz> References: <58f49a76.4c20.15712b20e40.Coremail.ypf@pku.edu.cn> <392727ce.b9c7.1572b385ece.Coremail.ypf@pku.edu.cn> <339617a6.8f06.1573166cbaf.Coremail.ypf@pku.edu.cn> <20160916072531.GB69806@kam.mff.cuni.cz> <355e6f53.95d3.1573230b35b.Coremail.ypf@pku.edu.cn> <20160916091417.GA29974@kam.mff.cuni.cz> <6ad18072.d732.15732c834ea.Coremail.ypf@pku.edu.cn> <20160916120037.GB3781@kam.mff.cuni.cz> From: Richard Biener Date: Tue, 20 Sep 2016 11:44:00 -0000 Message-ID: Subject: Re: [PATCH, 5.x/6.x/7.x] Be more conservative in early inliner if FDO is enabled To: Jan Hubicka Cc: "Yuan, Pengfei" , GCC Patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2016-09/txt/msg01274.txt.bz2 On Fri, Sep 16, 2016 at 2:00 PM, Jan Hubicka wrote: >> > > I also like a new param better as it avoids a new magic constant and >> > > makes playing with >> > > it easier (your patch removes the ability to do statistics like you did via the >> > > early-inlining-insns parameter by forcing it to two). >> > >> > Hmm, you are right that you do not know if this particular function will get >> > profile (forgot about that). Still, please use two params - it is more >> > consistent with what we have now and we may make it profile specific in >> > future.. >> > >> > Honza >> > > >> > > Thanks, >> > > Richard. >> >> A new patch for trunk is attached. >> >> Regards, >> Yuan, Pengfei >> >> >> 2016-09-16 Yuan Pengfei >> >> * doc/invoke.texi (--param early-inlining-insns-feedback): New. >> * ipa-inline.c (want_early_inline_function_p): Use >> PARAM_EARLY_INLINING_INSNS_FEEDBACK when FDO is enabled. >> * params.def (PARAM_EARLY_INLINING_INSNS_FEEDBACK): Define. >> (PARAM_EARLY_INLINING_INSNS): Change help string accordingly. Btw, It occurs to me that then win in code-size might be purely due to the smaller base value for the TU size we use to compute the maximum unit growth with ... any idea how to improve it on this side? Say, computing the TU size before early optimization (uh, probably not ...) That said, the inliner always completely fills its budged, that is, increase the unit by max-unit-growth? Richard. > OK, > thanks > > Honza