From: Richard Biener <richard.guenther@gmail.com>
To: Eric Botcazou <ebotcazou@adacore.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, Jeff Law <law@redhat.com>,
Qing Zhao <qing.zhao@oracle.com>,
GCC Development <gcc@gcc.gnu.org>
Subject: Re: A bug in vrp_meet?
Date: Mon, 06 May 2019 11:27:00 -0000 [thread overview]
Message-ID: <CAFiYyc1RLT7S6=ZEMqfJ4OrCn5PDLyb8c4VChcsWFoyjSjN+Rw@mail.gmail.com> (raw)
In-Reply-To: <9555693.KK0r0KSJNV@polaris>
On Sun, May 5, 2019 at 11:09 PM Eric Botcazou <ebotcazou@adacore.com> wrote:
>
> > I have now applied this variant.
>
> You backported it onto the 8 branch on Friday:
>
> 2019-05-03 Richard Biener <rguenther@suse.de>
>
> Backport from mainline
> [...]
> 2019-03-07 Richard Biener <rguenther@suse.de>
>
> PR tree-optimization/89595
> * tree-ssa-dom.c (dom_opt_dom_walker::optimize_stmt): Take
> stmt iterator as reference, take boolean output parameter to
> indicate whether the stmt was removed and thus the iterator
> already advanced.
> (dom_opt_dom_walker::before_dom_children): Re-iterate over
> stmts created by folding.
>
> and this introduced a regression for the attached Ada testcase at -O:
>
> Program received signal SIGSEGV, Segmentation fault.
> 0x000000000102173c in set_value_range (
> vr=0x17747a0 <vr_values::get_value_range(tree_node
> const*)::vr_const_varying>, t=VR_RANGE, min=0x7ffff6c3df78, max=<optimized
> out>, equiv=0x0)
> at /home/eric/svn/gcc-8-branch/gcc/tree-vrp.c:298
> 298 vr->type = t;
>
> on x86-64 at least. Mainline and 9 branch are not affected.
It looks like backporting r269597 might fix it though reverting that on trunk
doesn't make the testcase fail there.
Richard.
> --
> Eric Botcazou
next prev parent reply other threads:[~2019-05-06 11:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 17:57 Qing Zhao
2019-02-28 20:14 ` Jeff Law
2019-03-01 17:49 ` Qing Zhao
2019-03-01 19:25 ` Richard Biener
2019-03-01 21:02 ` Qing Zhao
2019-03-04 11:45 ` Richard Biener
2019-03-04 16:09 ` Qing Zhao
2019-03-04 22:01 ` Qing Zhao
2019-03-05 10:44 ` Richard Biener
2019-03-05 11:26 ` Richard Biener
2019-03-05 14:47 ` Richard Biener
2019-03-05 17:23 ` Qing Zhao
2019-03-05 21:53 ` Jeff Law
2019-03-06 10:09 ` Richard Biener
2019-03-07 13:44 ` Richard Biener
2019-05-05 21:09 ` Eric Botcazou
2019-05-06 11:27 ` Richard Biener [this message]
2019-03-19 20:26 ` Jeff Law
2019-03-20 9:36 ` Richard Biener
2019-03-05 17:10 ` Qing Zhao
2019-03-05 21:28 ` Jeff Law
2019-03-05 21:27 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiYyc1RLT7S6=ZEMqfJ4OrCn5PDLyb8c4VChcsWFoyjSjN+Rw@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gcc@gcc.gnu.org \
--cc=law@redhat.com \
--cc=qing.zhao@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).