From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by sourceware.org (Postfix) with ESMTPS id 721F03858D1E for ; Mon, 4 Apr 2022 13:21:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 721F03858D1E Received: by mail-ed1-x52b.google.com with SMTP id k2so3822271edj.9 for ; Mon, 04 Apr 2022 06:21:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AspSjEzF6Vw2K4nG+YBBtwtv4u7kMyQzFtss6f2CM60=; b=8Jq9bepVU4heXZinF4U4xDv3TZr1TkfXUTuRXeNShL1KJS/IaHBgl9RCBDxiJVDcsL eBstsmvujbtzuvrqc/cfkX4giHGAa4ksEtXmbopbYcn1LpoQWAOblPC7uibEmtEH8L8+ JMvapn2Uy748wY0iKaUqNqNZ9h2tVtrIzJDPj0XVgbPpgnWapTizSllgLxBV/8mT4QQu atknAC107vO8gvQCI8BGMlGqtyvLglg47vQfhuDDbHHxIvabQge3BXPzAtnh8YeTTSuS WNlwZqTqt0dMjidJQ37A5/Q0lPOWdVLW7a2UE3gU0JeljUZH4R9eCDi/CwZQBeJS6TNd 6Wlg== X-Gm-Message-State: AOAM532XltyM59xZDzgdbOqMK0byyjpll/EUzlHr7/OXUKgis59cy/Bp EnFcz6LEpHkkaAd+oxO+SF/9Q+G39OR9Gh5w4Vk= X-Google-Smtp-Source: ABdhPJzA7rYB3zL6SWN45kxuJa2Xw6QBLpvmU+UiSaWse1Ig8gjYrwfH5BitpS3rSpcsSrHVnnx485X4xWrB5usN6a4= X-Received: by 2002:aa7:d543:0:b0:416:13eb:6fec with SMTP id u3-20020aa7d543000000b0041613eb6fecmr33512370edr.348.1649078511108; Mon, 04 Apr 2022 06:21:51 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Richard Biener Date: Mon, 4 Apr 2022 15:21:40 +0200 Message-ID: Subject: Re: [PATCH] testsuite: Add -fno-tree-loop-distribute-patterns for s390. To: Robin Dapp Cc: GCC Patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Apr 2022 13:21:54 -0000 On Mon, Apr 4, 2022 at 1:52 PM Robin Dapp via Gcc-patches wrote: > > Hi, > > in gcc.dg/Wuse-after-free-2.c we try to detect a use-after-free. On > s390 the test's while loop is converted into a rawmemchr builtin making > it impossible to determine that the pointers *p and *q are related. > > Therefore, disable the tree loop distribute patterns pass on s390 for > this test. > > OK for trunk? > > Regards > Robin > > gcc/testsuite/ChangeLog: > > * gcc.dg/Wuse-after-free-2.c: > Add -fno-tree-loop-distribute-patterns for s390*. > > > --- > diff --git a/gcc/testsuite/gcc.dg/Wuse-after-free-2.c > b/gcc/testsuite/gcc.dg/Wuse-after-free-2.c > index 9f7ed4529f0..3a8f690e9f8 100644 > --- a/gcc/testsuite/gcc.dg/Wuse-after-free-2.c > +++ b/gcc/testsuite/gcc.dg/Wuse-after-free-2.c > @@ -1,6 +1,8 @@ > /* PR middle-end/104232 - spurious -Wuse-after-free after conditional free > { dg-do compile } > - { dg-options "-O2 -Wall" } */ > + { dg-options "-O2 -Wall" } > + { dg-additional-options "-fno-tree-loop-distribute-patterns" { > target { s390*-*-* } } } Please add the option unconditional and add a comment wrt rawmemchr OK with that change. > + */ > > void free (void*); > > -- > 2.35.1 >