public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Biener <richard.guenther@gmail.com>
To: Austin Morton <austinpmorton@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] c: Silently ignore pragma region [PR85487]
Date: Mon, 31 Aug 2020 10:06:15 +0200	[thread overview]
Message-ID: <CAFiYyc1V4fR75e2jOChUWmFB9Cor8VNWhRT2vL9jNdYOa3nbSA@mail.gmail.com> (raw)
In-Reply-To: <CAPWKHJQC=HP9oxFUryJOyS4cHZ9GEoCjtEJrC7On76MTRvr-dQ@mail.gmail.com>

On Fri, Aug 28, 2020 at 10:04 PM Austin Morton <austinpmorton@gmail.com> wrote:
>
> > The patch misses documentation of the pragma.
>
> This was an intentional omission - when looking for documentation of
> the pragma in clang I found none.
>
> If we do want to document the pragmas in GCC:
>  - what section of the documentation would that go in?
>     - gcc/doc/cpp.texi, section 7, "Pragmas"
>         - this section states: "This manual documents the pragmas
> which are meaningful to the preprocessor itself. Other pragmas are
> meaningful to the C or C++ compilers. They are documented in the GCC
> manual."
>         - these pragmas aren't exactly meaningful to the preprocessor
> _or_ the C/C++ compiler, so it's not exactly clear where they fit.
>     - gcc/doc/extend.texi, section 6.62, "Pragmas Accepted by GCC"
>  - what exactly would it say?
>     - I guess just mention the existence and that they won't trigger
> unknown pragma warnings? They don't _do_ anything

Yes, documenting their existance and their zero effect.

Richard.

>
> Austin

      reply	other threads:[~2020-08-31  8:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-28  1:25 Austin Morton
2020-08-28  7:20 ` Richard Biener
2020-08-28 20:04   ` Austin Morton
2020-08-31  8:06     ` Richard Biener [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFiYyc1V4fR75e2jOChUWmFB9Cor8VNWhRT2vL9jNdYOa3nbSA@mail.gmail.com \
    --to=richard.guenther@gmail.com \
    --cc=austinpmorton@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).