From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by sourceware.org (Postfix) with ESMTPS id EE04B3858D1E for ; Fri, 9 Jun 2023 08:58:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EE04B3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2b1b8593263so16089581fa.2 for ; Fri, 09 Jun 2023 01:58:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686301106; x=1688893106; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=iuqIsicg/bOoFcBgXQGM5GGbfaJbZxZX0pyJ8iEQars=; b=VOQghy9uFUKfjM5EeJBnWUrKAgoR0V2gCg7fi+ETDAi3TSyeZrAQn7ydk6NiUN88AU FP5cGyQesFDuKcPcspkvuPyp6g/r0JqkfnZBGBKZMbAs2uj4zaMl9oH9v0eModYU0LS3 fUnoGCxm7sZuQKs5aGTM1RdE9kcDrSnbKh9Oyjhxq3ZWfLJxmj77YmiMCsDHxr/aZsUd aFCwD36TmK6gBHDU4yHJg+Wf5Ws6JCltiHYc6RKyZmNujUU0urkclf2HWLBbHMOcyz7E H4Gl+D6C8rxeh4EgWWauRoqVI0kQCqmsvU04v2cnHvsr67nafYGXIHIlo80mOffIbotE m/bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686301106; x=1688893106; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iuqIsicg/bOoFcBgXQGM5GGbfaJbZxZX0pyJ8iEQars=; b=h39Nde+QLsyKihkyc9ywkQqYKRWAoN1szzXBPb/+BpoQHayLULf/1WSBZvRp6BWw3/ 1xkNSXIrdxWILOGLvlb2EI9Tgiua7YryzCEkDShQGv/dbsa1uodYD5RhM4l3UWr5F7hi U6iiKwYLr7PNc57YfYfjm3YOHfzPIl/ODiBBk6U1LAyApIqxeoyCM5g8ffUlcELG43KF Q9hjLWycdcRZ1bJ1azT5nfpNg4jA4rhWZ64PGclNwtRozbsUtpeztz7yoTukjxLqROgI luzW+Pm0U8WRx9/OWNTCtsKYavlo7g7u+zaqRYXMl+BfZy4HQzJq9McOSQAlDcH7i+ft xu5w== X-Gm-Message-State: AC+VfDzYjVVxfFShu8dyLFZoJOsp/CNjQdFogwUk4w8kKjnkqFj9HeZA MnCi2pr52mvHx/6iWSgw15/lUn4+Gi0MILzDuKI= X-Google-Smtp-Source: ACHHUZ70GEorBSGPo6BaqOk+yucOB/lmPliXSdDco232X/7VTZReO8gzs9NkkszRAMQleuMetIm+een0EXTlZ7MEkD0= X-Received: by 2002:a05:651c:c3:b0:2af:1622:a69 with SMTP id 3-20020a05651c00c300b002af16220a69mr591120ljr.48.1686301106004; Fri, 09 Jun 2023 01:58:26 -0700 (PDT) MIME-Version: 1.0 References: <20230608112351.207461-1-lehua.ding@rivai.ai> In-Reply-To: <20230608112351.207461-1-lehua.ding@rivai.ai> From: Richard Biener Date: Fri, 9 Jun 2023 10:58:13 +0200 Message-ID: Subject: Re: [PATCH] testsuite: fix the condition bug in tsvc s176 To: Lehua Ding Cc: gcc-patches@gcc.gnu.org, mliska@suse.cz Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Jun 8, 2023 at 1:24=E2=80=AFPM Lehua Ding wro= te: > > Hi, > > This patch fixes the problem that the loop in the tsvc s176 function is > optimized and removed because `iterations/LEN_1D` is 0 (where iterations > is set to 10000, LEN_1D is set to 32000 in tsvc.h). > > This testcase passed on x86 and AArch64 system. OK. It's odd that the checksum doesn't depend on the number of iterations done = ... > Best, > Lehua > > gcc/testsuite/ChangeLog: > > * gcc.dg/vect/tsvc/vect-tsvc-s176.c: adjust iterations > > --- > gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s176.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s176.c b/gcc/testsu= ite/gcc.dg/vect/tsvc/vect-tsvc-s176.c > index 79faf7fdb9e4..365e5205982b 100644 > --- a/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s176.c > +++ b/gcc/testsuite/gcc.dg/vect/tsvc/vect-tsvc-s176.c > @@ -14,7 +14,7 @@ real_t s176(struct args_t * func_args) > initialise_arrays(__func__); > > int m =3D LEN_1D/2; > - for (int nl =3D 0; nl < 4*(iterations/LEN_1D); nl++) { > + for (int nl =3D 0; nl < 4*(10*iterations/LEN_1D); nl++) { > for (int j =3D 0; j < (LEN_1D/2); j++) { > for (int i =3D 0; i < m; i++) { > a[i] +=3D b[i+m-j-1] * c[j]; > @@ -39,4 +39,4 @@ int main (int argc, char **argv) > return 0; > } > > -/* { dg-final { scan-tree-dump "vectorized 1 loops" "vect" { xfail *-*-*= } } } */ > +/* { dg-final { scan-tree-dump "vectorized 1 loops" "vect" } } */ > -- > 2.36.1 >