From: Richard Biener <richard.guenther@gmail.com>
To: Andrew MacLeod <amacleod@redhat.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] tree-optimization/103551 - Always set EDGE_EXECUTABLE in ranger vrp.
Date: Wed, 12 Jan 2022 10:02:22 +0100 [thread overview]
Message-ID: <CAFiYyc1WkTMMi8n7m8hsNPyJ3bPGnKD5ALwnzk9mYX=ZZ0cEZw@mail.gmail.com> (raw)
In-Reply-To: <5d69d8fd-03c0-07e2-1031-41ed502fcee0@redhat.com>
On Tue, Jan 11, 2022 at 8:49 PM Andrew MacLeod via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> The simplify_and_fold engine uses the EDGE_EXECUTABLE flag to eliminate
> branches:
>
> substitute_and_fold_dom_walker::before_dom_children:
>
> if (gimple_code (stmt) == GIMPLE_COND)
> {
> if ((EDGE_SUCC (bb, 0)->flags & EDGE_EXECUTABLE)
> ^ (EDGE_SUCC (bb, 1)->flags & EDGE_EXECUTABLE))
>
> ... but if certain passes before VRP2 are turned off, the flag can be in
> an uninitialized state upon entry to VRP2. This patch simply always
> sets EDGE_EXECUTABLE on all edges before invoking ranger and the S&F engine.
>
> Bootstraps on x86_64-pc-linux-gnu with no regressions.
>
> OK for trunk?
OK.
> Andrew
>
>
>
>
>
prev parent reply other threads:[~2022-01-12 9:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 19:48 Andrew MacLeod
2022-01-12 9:02 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiYyc1WkTMMi8n7m8hsNPyJ3bPGnKD5ALwnzk9mYX=ZZ0cEZw@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=amacleod@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).