From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <richard.guenther@gmail.com>
Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com
 [IPv6:2a00:1450:4864:20::529])
 by sourceware.org (Postfix) with ESMTPS id D8B15393A419
 for <gcc-patches@gcc.gnu.org>; Wed, 12 Jan 2022 09:02:33 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D8B15393A419
Received: by mail-ed1-x529.google.com with SMTP id o6so7139142edc.4
 for <gcc-patches@gcc.gnu.org>; Wed, 12 Jan 2022 01:02:33 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=SQRKcMY9yngeP2CeEtPz7yUomQA1sGYsVcoB+xNqwQc=;
 b=SOQNyQznybGIkFpJaYTrdejd2zg4AUdWQJKYK1Fivi9Tw275UjiIUo2GpZS8/C9hsl
 mDlYpaWYj7Oh1dzgg30BRcMAXdTrd7OcNbTduHnqR65L9v8sjVx+BqMG/S1Elv7w4ipq
 YkFd5toQlFzsAfOJVzrsj2lyN+AjOXnPb1gSF9Tx3yfn1vhQIUWSwHL2m8IgTQrrr+OW
 fUX5SGCXueJ20MTST0F2TOwRzlC7ntmHi/pA7mFU053lZOT+E9/g5rDipVd6I2F9DjsH
 SXcfwRXYUil0XGZwwSr1eiBsaL6qPoCSkMU2ya3KUSU7XRyR+8z5Y/QFLVW8dbb3coAd
 J62A==
X-Gm-Message-State: AOAM530Z3I7s0aQlcrJWt9cyN5NMxaou8SvCs5VQ66qnb2X7xlIFFYJf
 batNXssiKSvObEzZVJvnSKOD4GcluLMbI3C4h9g=
X-Google-Smtp-Source: ABdhPJzYHCRYGM9fKUb76Q59M8A+JtJSau0DGWBwdLy4LrISa3Wj+D7AZNUeK1xCHdPNkjkr2uo03OjC+lzUfosld1E=
X-Received: by 2002:a05:6402:d05:: with SMTP id
 eb5mr8043493edb.345.1641978152867; 
 Wed, 12 Jan 2022 01:02:32 -0800 (PST)
MIME-Version: 1.0
References: <5d69d8fd-03c0-07e2-1031-41ed502fcee0@redhat.com>
In-Reply-To: <5d69d8fd-03c0-07e2-1031-41ed502fcee0@redhat.com>
From: Richard Biener <richard.guenther@gmail.com>
Date: Wed, 12 Jan 2022 10:02:22 +0100
Message-ID: <CAFiYyc1WkTMMi8n7m8hsNPyJ3bPGnKD5ALwnzk9mYX=ZZ0cEZw@mail.gmail.com>
Subject: Re: [PATCH] tree-optimization/103551 - Always set EDGE_EXECUTABLE in
 ranger vrp.
To: Andrew MacLeod <amacleod@redhat.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Jan 2022 09:02:35 -0000

On Tue, Jan 11, 2022 at 8:49 PM Andrew MacLeod via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> The simplify_and_fold engine uses the EDGE_EXECUTABLE flag to eliminate
> branches:
>
> substitute_and_fold_dom_walker::before_dom_children:
>
>       if (gimple_code (stmt) == GIMPLE_COND)
>          {
>            if ((EDGE_SUCC (bb, 0)->flags & EDGE_EXECUTABLE)
>                ^ (EDGE_SUCC (bb, 1)->flags & EDGE_EXECUTABLE))
>
> ... but if certain passes before VRP2 are turned off, the flag can be in
> an uninitialized state upon entry to VRP2.  This patch simply always
> sets EDGE_EXECUTABLE on all edges before invoking ranger and the S&F engine.
>
> Bootstraps on  x86_64-pc-linux-gnu with no regressions.
>
> OK for trunk?

OK.

> Andrew
>
>
>
>
>