From: Richard Biener <richard.guenther@gmail.com>
To: marxin <mliska@suse.cz>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 3/4] Replace ENABLE_CHECKING with CHECKING_P in dwarf2out
Date: Fri, 26 Feb 2016 10:43:00 -0000 [thread overview]
Message-ID: <CAFiYyc1Y-afuHzFU07bQHT+8Rr5-vVoVnXarkt7hE1goHZ86hw@mail.gmail.com> (raw)
In-Reply-To: <f05bebc674ace2795f34d7a2f3950ecd4a4c6b09.1456409352.git.mliska@suse.cz>
On Thu, Feb 25, 2016 at 11:06 AM, marxin <mliska@suse.cz> wrote:
> gcc/ChangeLog:
Ok.
Richard.
> 2016-02-25 Martin Liska <mliska@suse.cz>
>
> * dwarf2out.c (new_loc_descr): Replace ENABLE_CHECKING with
> CHECKING_P.
> (resolve_args_picking_1): Likewise.
> * dwarf2out.h (struct GTY): Likewise.
> ---
> gcc/dwarf2out.c | 6 +++---
> gcc/dwarf2out.h | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/gcc/dwarf2out.c b/gcc/dwarf2out.c
> index 97e192b..a8c21d8 100644
> --- a/gcc/dwarf2out.c
> +++ b/gcc/dwarf2out.c
> @@ -1325,7 +1325,7 @@ new_loc_descr (enum dwarf_location_atom op, unsigned HOST_WIDE_INT oprnd1,
> dw_loc_descr_ref descr = ggc_cleared_alloc<dw_loc_descr_node> ();
>
> descr->dw_loc_opc = op;
> -#if ENABLE_CHECKING
> +#if CHECKING_P
> descr->dw_loc_frame_offset = -1;
> #endif
> descr->dw_loc_oprnd1.val_class = dw_val_class_unsigned_const;
> @@ -15369,14 +15369,14 @@ resolve_args_picking_1 (dw_loc_descr_ref loc, unsigned initial_frame_offset,
> /* If we already met this node, there is nothing to compute anymore. */
> if (visited.add (l))
> {
> -#if ENABLE_CHECKING
> +#if CHECKING_P
> /* Make sure that the stack size is consistent wherever the execution
> flow comes from. */
> gcc_assert ((unsigned) l->dw_loc_frame_offset == frame_offset_);
> #endif
> break;
> }
> -#if ENABLE_CHECKING
> +#if CHECKING_P
> l->dw_loc_frame_offset = frame_offset_;
> #endif
>
> diff --git a/gcc/dwarf2out.h b/gcc/dwarf2out.h
> index a96ac38..91b3d6b 100644
> --- a/gcc/dwarf2out.h
> +++ b/gcc/dwarf2out.h
> @@ -239,7 +239,7 @@ struct GTY((chain_next ("%h.dw_loc_next"))) dw_loc_descr_node {
> frame offset. */
> unsigned int frame_offset_rel : 1;
> int dw_loc_addr;
> -#if ENABLE_CHECKING
> +#if CHECKING_P
> /* When translating a function into a DWARF procedure, contains the frame
> offset *before* evaluating this operation. It is -1 when not yet
> initialized. */
> --
> 2.7.0
>
>
prev parent reply other threads:[~2016-02-26 10:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 15:35 [PATCH 0/4] Replace remaining ENABLE_CHECKING macros marxin
2016-02-25 15:35 ` [PATCH 1/4] Replace ENABLE_CHECKING macro with flag_checking in HSA marxin
2016-02-25 17:18 ` Martin Jambor
2016-02-25 15:35 ` [PATCH 2/4] Replace ENABLE_CHECKING macro with flag_checking in GNAT marxin
2016-02-26 21:28 ` Jeff Law
2016-02-25 15:35 ` [PATCH 4/4] Poison ENABLE_CHECKING macro marxin
2016-02-26 10:43 ` Richard Biener
2016-02-25 15:35 ` [PATCH 3/4] Replace ENABLE_CHECKING with CHECKING_P in dwarf2out marxin
2016-02-26 10:43 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc1Y-afuHzFU07bQHT+8Rr5-vVoVnXarkt7hE1goHZ86hw@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mliska@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).