public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Biener <richard.guenther@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Yuri Rumyantsev <ysrumyan@gmail.com>,
	gcc-patches <gcc-patches@gcc.gnu.org>,
		Igor Zamyatin <izamyatin@gmail.com>
Subject: Re: [PATCH PR64434]
Date: Wed, 14 Jan 2015 14:07:00 -0000	[thread overview]
Message-ID: <CAFiYyc1Y0iomFXDuLAaQ9CzEvFAEP1kPv3yLMxRwwfNbFb4mzw@mail.gmail.com> (raw)
In-Reply-To: <20150114133336.GQ1405@tucnak.redhat.com>

On Wed, Jan 14, 2015 at 2:33 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Wed, Jan 14, 2015 at 04:28:42PM +0300, Yuri Rumyantsev wrote:
>> Hi All,
>>
>> I did all changes proposed by Richard and delete check on def in the
>> same block as Jakub proposed.
>> I also moved check  on optimization to call site..
>>
>> I also checked that bootstrap and regression testing did not show any
>> new failures.
>>
>> Is it OK for trunk?
>
> The  | SSA_OP_VUSE is still in there, the testcase is still executable,
> still doesn't end with newline, and I really think you should replace
>   lattice = XALLOCAVEC (unsigned int, n);
> with something like:
>   if (n >= 100000)
>     lattice = XNEWVEC (unsigned int, n);
>   else
>     lattice = XALLOCAVEC (unsigned int, n);
> ...
>   if (n >= 100000)
>     XDELETE (lattice);
> or similar.

Just unconditionally allocate from the heap.

Richard.

>
>         Jakub

  reply	other threads:[~2015-01-14 13:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-14 10:17 Yuri Rumyantsev
2015-01-14 10:38 ` Jakub Jelinek
2015-01-14 10:40   ` Yuri Rumyantsev
2015-01-14 10:58     ` Jakub Jelinek
2015-01-14 11:14       ` Richard Biener
2015-01-14 11:15         ` Jakub Jelinek
2015-01-14 13:37           ` Yuri Rumyantsev
2015-01-14 13:49             ` Jakub Jelinek
2015-01-14 14:07               ` Richard Biener [this message]
2015-01-14 14:26               ` Yuri Rumyantsev
2015-01-15 10:13                 ` Yuri Rumyantsev
2015-01-15 11:17                   ` Richard Biener

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFiYyc1Y0iomFXDuLAaQ9CzEvFAEP1kPv3yLMxRwwfNbFb4mzw@mail.gmail.com \
    --to=richard.guenther@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=izamyatin@gmail.com \
    --cc=jakub@redhat.com \
    --cc=ysrumyan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).