From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id 155E93861800 for ; Thu, 15 Jul 2021 07:58:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 155E93861800 Received: by mail-ej1-x62c.google.com with SMTP id oz7so3994708ejc.2 for ; Thu, 15 Jul 2021 00:58:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=M5ng/BYo9RmMePp9tuWLmX0urxlBV6K5hiaKs6ZLZBY=; b=llZXKgGSHMyeZY9Tj8BdQB3xAgAwSUfSCn/KxK1a8tW1oEng4L7SQkmluo3vVXjeqC XrNmLAPmYlK/kYwqukTIy8ZmSQOPDLncb9KEUuAhT7/F3ETEzJDsDRy4ca+pcNflZwtW hXqfo1cLqwHEFyO97oPRVKNzt4C/3CRGyknxtwHxYgHEcLV5XOqWdu0IfEi87mD5u7tQ a2URh2l6efgZAFVfvn97Chqn2qbRLlb+y4CF2md5+agQu5xIL0v7W7TKFf/0e/eZs+Bu 7ePw9s6n4AS5iP4tBGF2bPLszzrfjMCtv1/Z88xXWVgK5gLLb/a8XxWWW8Wpb7yCer9g do0A== X-Gm-Message-State: AOAM533U0mFlxBJG7vUxKH0j++Kvv4CwBRHd1AXL7hgE5gw1mLAOfNJq 7ZGb4o80ITzwohLU/SSYUEFJnC+Gz22UDutHnfFnBVPm X-Google-Smtp-Source: ABdhPJwZc9o8Y74LSmYnEixC/b36mK6kFHPzYMhcZWHlcNBtvFU20rZAS1ZCaCQPt0XOmsPVsLLKCnp9N09J5HpUCrw= X-Received: by 2002:a17:906:dfdb:: with SMTP id jt27mr4210079ejc.138.1626335908140; Thu, 15 Jul 2021 00:58:28 -0700 (PDT) MIME-Version: 1.0 References: <79e96909-5e54-316f-fb8a-9954ea4c6460@linux.alibaba.com> In-Reply-To: <79e96909-5e54-316f-fb8a-9954ea4c6460@linux.alibaba.com> From: Richard Biener Date: Thu, 15 Jul 2021 09:58:16 +0200 Message-ID: Subject: Re: [PATCH] Remove legacy external declarations in toplev.h [PR101447] To: ashimida Cc: GCC Patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jul 2021 07:58:30 -0000 On Thu, Jul 15, 2021 at 3:54 AM ashimida via Gcc-patches wrote: > > > External declarations in ./gcc/toplev.h is no longer used in newest > version of gcc and should be cleaned up to avoid misunderstandings. OK > gcc/ChangeLog: > > * toplev.h (set_random_seed): > > --- > diff --git a/gcc/toplev.h b/gcc/toplev.h > index 175944c..f543554 100644 > --- a/gcc/toplev.h > +++ b/gcc/toplev.h > @@ -94,11 +94,6 @@ extern bool set_src_pwd (const > char *); > extern HOST_WIDE_INT get_random_seed (bool); > extern void set_random_seed (const char *); > > -extern unsigned int min_align_loops_log; > -extern unsigned int min_align_jumps_log; > -extern unsigned int min_align_labels_log; > -extern unsigned int min_align_functions_log; > - > extern void parse_alignment_opts (void); > > extern void initialize_rtl (void); > > --- > The history FYI: > https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=e6de53356769e13178975c18b4ce019a800ea946;hp=118f2d8bc3e6804996ca2953b86454ec950054bf >