From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by sourceware.org (Postfix) with ESMTPS id 07DF73858D1E for ; Tue, 18 Apr 2023 06:24:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 07DF73858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-x229.google.com with SMTP id j11so16707300ljq.10 for ; Mon, 17 Apr 2023 23:24:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681799053; x=1684391053; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=krlYxH9Sb9EUtmMUBodDlJSrMH4T9T9Vablxrf1I5Dw=; b=OU8i6GPn9MRYMxDtXEG7v16P5/BjlZ0aVKmYTJZaTxxB1zSzyVVyb2N83CLEVPnchR CSnIWDDpI6qySwcHOTtp0yOQwNGcz98+3jrCKjOf2DyrDmS6z7uS8bF1sb/jLvaXQh26 ekjY027U0Fuhqg8F5h27BMmF+OdI+XLliJECSINGs+bjijsu7TEjgipq98bR24Y/T9an fYQtuhxZw0qyMoDflvfnWbbXHSqck2FU3WCh1kUhPbev+5N+3IIFHY8E95GyEJOxmh6U PYy66dokIfjPEjCiuyWGWKKivNort+OS0eCIy3TgCyuFjYSGMjmEzedgDnhUyBFuC1qy Xf+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681799053; x=1684391053; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=krlYxH9Sb9EUtmMUBodDlJSrMH4T9T9Vablxrf1I5Dw=; b=OEInuUeKAkxxxiLld/B99AtAO1awQjtznAiidEv4C4rFyzzTyH9A9VYjlAL6xi9XZ6 34cmIPV/UNWqGN+hZVlFmyaL4Iy9NhMb7FSl9BIuzI7DqO02Phgz7Lo0/MT+kzNMbmH1 hUrZukILNDoS1QEjobD0j3knz1U2w1e2snaImYeCwl7b9rz8dbqbQQ8ryN5U1NIy/WtC cjf4W0jB9O0nPOS/3O0Ee2nmrmwyU3IIDKI7GKADBHNBj4s1x0Bm6h7CqqQykf6pZiog YNGmnlAnxLRZrnTHIJRwLua51XT/ddfm2o9b6n6HwqIWqLe7XpLa8WOonoTN7azsiO7M EpiQ== X-Gm-Message-State: AAQBX9fYrA69wRed07P9g9RXJJvl/o1DLujjNGitXAxUAD8QB7Y0u0iT RPRGO3T0uszzSd7ao+uXIzH8WN7iKofArPxGAQo= X-Google-Smtp-Source: AKy350Z/wexlBaOorpjeLv3NiOnxHnQBrJHynyh7tXvYD8q/Zc+Byx7Xe5Kt7Fj+HJDhsKc4hn97QaXvS4ssfUtdwKM= X-Received: by 2002:a2e:834e:0:b0:2a7:8607:2e64 with SMTP id l14-20020a2e834e000000b002a786072e64mr461951ljh.3.1681799053434; Mon, 17 Apr 2023 23:24:13 -0700 (PDT) MIME-Version: 1.0 References: <20230417221740.251864-1-apinski@marvell.com> In-Reply-To: <20230417221740.251864-1-apinski@marvell.com> From: Richard Biener Date: Tue, 18 Apr 2023 08:24:01 +0200 Message-ID: Subject: Re: [PATCH 1/2] PHIOPT: small cleanup in match_simplify_replacement To: Andrew Pinski Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Apr 18, 2023 at 12:18=E2=80=AFAM Andrew Pinski via Gcc-patches wrote: > > We know that the statement we are moving is already > have a SSA_NAME on the lhs so we don't need to > check that and can also just call reset_flow_sensitive_info > with the name we already got. > > OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions. OK. > gcc/ChangeLog: > > * tree-ssa-phiopt.cc (match_simplify_replacement): > Simplify code that does the movement slightly. > --- > gcc/tree-ssa-phiopt.cc | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/gcc/tree-ssa-phiopt.cc b/gcc/tree-ssa-phiopt.cc > index 16acd2f1894..4ddb4d5db90 100644 > --- a/gcc/tree-ssa-phiopt.cc > +++ b/gcc/tree-ssa-phiopt.cc > @@ -1094,11 +1094,10 @@ match_simplify_replacement (basic_block cond_bb, = basic_block middle_bb, > > tree name =3D gimple_get_lhs (stmt_to_move); > // Mark the name to be renamed if there is one. > - if (name && TREE_CODE (name) =3D=3D SSA_NAME) > - bitmap_set_bit (inserted_exprs, SSA_NAME_VERSION (name)); > + bitmap_set_bit (inserted_exprs, SSA_NAME_VERSION (name)); > gimple_stmt_iterator gsi1 =3D gsi_for_stmt (stmt_to_move); > gsi_move_before (&gsi1, &gsi); > - reset_flow_sensitive_info (gimple_assign_lhs (stmt_to_move)); > + reset_flow_sensitive_info (name); > } > > replace_phi_edge_with_variable (cond_bb, e1, phi, result, inserted_exp= rs); > -- > 2.31.1 >